Page MenuHomeFreeBSD

Mark errf _Noreturn and mark errf and warn __printflike
ClosedPublic

Authored by ngie on May 13 2017, 8:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 28 2023, 11:07 PM
Unknown Object (File)
Jul 25 2023, 8:14 PM
Unknown Object (File)
Jun 15 2023, 10:03 AM
Unknown Object (File)
Jun 3 2023, 1:25 AM
Unknown Object (File)
Jan 16 2023, 6:33 PM
Unknown Object (File)
Dec 28 2022, 10:12 AM
Unknown Object (File)
Dec 17 2022, 1:43 AM
Subscribers

Details

Summary

Mark errf _Noreturn and mark errf and warn __printflike

The _Noreturn attribute was added to placate Coverity and other static
analysis tools. The __printflike attribute was added to catch issues
with the calls related to printf(3) abuse.

  • Modify the code to facilitate the __printflike attribute addition.
  • Convert errf calls in to_mb(..) and to_mb_string(..) to warn(..) so the calls will return instead of exiting, as the code suggests it should.

MFC after: 1 month
Sponsored by: Dell EMC Isilon

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

usr.bin/localedef/localedef.h
58 ↗(On Diff #28300)

_Noreturn should go first, right before the void.

Update with feedback from pfg

This revision is now accepted and ready to land.May 14 2017, 1:25 AM