archivers/brotli: Update to 0.6.0 - Update brotli to 0.6.0 - Move from devel/libbrotli - No longer requires the meta project - Switch from autoconf to cmake - Fix nginx brotli module PR: 218851 Submitted by: Markus Kohlmeyer <rootservice@gmail.com> Reviewed_by: Approved by: Differential_Revision
Details
Details
- Reviewers
mat i.dani_outlook.com - Commits
- rP445604: archivers/brotli: Move and update to 0.6.0
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Allow static build as well
From: https://bz-attachments.freebsd.org/attachment.cgi?id=182113
Comment Actions
Add libbrotli*.so.0 symlinks
As per request in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218851#c2
Comment Actions
@mat See inline comment
| archivers/brotli/Makefile | ||
|---|---|---|
| 24 ↗ | (On Diff #29904) | I think this is a problem of brotli itself - it's not possible to have both types of libraries. See: |
| archivers/brotli/Makefile | ||
|---|---|---|
| 24 ↗ | (On Diff #29904) | Then create a archivers/brotli-static with and use OPTIONS_EXCLUDE=STATIC/OPTIONS_SLAVE=STATIC |
| archivers/brotli/Makefile | ||
|---|---|---|
| 24 ↗ | (On Diff #29904) | Or just do not provide an option to get static libs, nobody should ever be using them. |
Comment Actions
Set PORTEPOCH
Even though we're moving to a different name, we're going
back in version 1.0 -> 0.6.0
| archivers/brotli/Makefile | ||
|---|---|---|
| 24 ↗ | (On Diff #29904) | Agree. This was on request of osa@ (see PR). Gone now. |
Comment Actions
Add patch for nginx
- Update nginx brotli module
As far as I can tell nginx is the only user of devel/libbrotli
Comment Actions
Add archivers/brotli-static port and www/nginx-devel update
- Add static port on maintainers request
- Update nginx-devel port brotli module
Comment Actions
The only other dependency I've found is in mail/cyrus-imapd30 where it is commented out, with the new archivers/brotli this builds fine
-# Our libbrotli is too old -#HTTP_LIB_DEPENDS+= libbrotlidec.so:devel/libbrotli +HTTP_LIB_DEPENDS+= libbrotlicommon.so:archivers/brotli
Comment Actions
Could you not rewrite other port's Makefiles ? most of nginx-devel should not be in here.
Comment Actions
Also, is there any need for the static stuff ? Using static libraries is a pain in the ports tree. Also ELF has been here for 20 years, nobody should be using or providing static libs, ever.
| archivers/brotli-static/Makefile | ||
|---|---|---|
| 10 ↗ | (On Diff #30576) | Simply write: CONFLICTS_INSTALL= brotli |
| archivers/brotli/Makefile | ||
| 15 ↗ | (On Diff #30576) | This should be ?=, and also only brotli-static. |
| 20 ↗ | (On Diff #30576) | So one can ask the brotli port to build as STATIC, this is not really great. Maybe simply drop options and use a .if defined(STATIC_ONLY) / .else |
Comment Actions
Committed only the shared-lib version.
Maintainer of the port (who requested static option) didn't provide feedback (via mail)