Check the thread pointer stored in the thread context is valid.
AbandonedPublic
Actions

Authored by andrew on Jan 24 2015, 8:39 PM.

Details

Reviewers

None

Group Reviewers

Summary

Check the thread pointer stored in the thread context is valid at all
points we read it from the special register, and when entering and
exiting system calls.

The later case is because the system call could be to change this value.
They are there to verify the code correctly sets this data in the thread
context.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

andrew updated this revision to Diff 3388.Jan 24 2015, 8:39 PM

andrew retitled this revision from to Check the thread pointer stored in the thread context is valid..

andrew updated this object.

andrew edited the test plan for this revision. (Show Details)

andrew added a reviewer: ARM.

• ian subscribed.Jan 24 2015, 9:09 PM

• ian added inline comments.

sys/arm/arm/locore-v6.S
174	shouldn't this be done in mpentry too?

andrew added inline comments.Jan 24 2015, 10:01 PM

sys/arm/arm/locore-v6.S
174	Yes.

Set the thread pointer when new cores are started

Only very minor nits. See inline comments.

sys/arm/arm/sys_machdep.c

100

Access to CP15 tls register is relatively slow. Something like this looks better for me:

	td->td_retval[0] = td->td_md.md_tp;
#ifndef ARM_TP_ADDRESS
	KASSERT((register_t)get_tls() == td->td_md.md_tp,
	    ("arm32_get_tp: Invalid TLS pointer (%x != %x)",
	    (register_t)get_tls(), td->td_md.md_tp));
#else
	if (td == curthread)
		td->td_retval[0] = *(register_t *)ARM_TP_ADDRESS;
#endif

sys/arm/arm/vm_machdep.c

151

ditto: