Page MenuHomeFreeBSD

sfxge(4): ensure EvQ poll stops when abort is requested
ClosedPublic

Authored by arybchik on Nov 21 2018, 11:59 AM.
Tags
None
Referenced Files
F81970605: D18287.diff
Sat, Dec 14, 7:33 PM
Unknown Object (File)
Jan 11 2024, 10:00 PM
Unknown Object (File)
Dec 20 2023, 2:23 AM
Unknown Object (File)
Nov 18 2023, 10:52 PM
Unknown Object (File)
Nov 18 2023, 1:14 PM
Unknown Object (File)
Nov 18 2023, 11:45 AM
Unknown Object (File)
Nov 14 2023, 6:38 PM
Unknown Object (File)
Sep 4 2023, 3:28 PM
Subscribers

Details

Summary

If an event handler requested an abort, only the inner loop was
guarenteed to be broken out of - the outer loop could continue
if total == batch.

Fix this by poisoning batch to ensure it is different to total.

Submitted by: Mark Spender <mspender at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:11 AM
This revision was automatically updated to reflect the committed changes.