Fix nmtree crashing with duplicate items
Needs ReviewPublic
Actions

Authored by renato.riolino_eldorado.org.br on Jan 20 2020, 5:21 PM.

Details

Reviewers

brooks
kib
emaste

Summary

Bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192839

If the addchild() function finds that the current item is already in the linked list, it overrides the duplicated item with the new one and then free() the new one, but the calling function would still reference the new item that was freed.

Test Plan

nmtree -dEU <<EOF

.
item
item
..
EOF

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 28815
Build 26823: arc lint + arc unit

Event Timeline

renato.riolino_eldorado.org.br created this revision.Jan 20 2020, 5:21 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 20 2020, 5:21 PM

Harbormaster completed remote builds in B28787: Diff 67052.Jan 20 2020, 5:21 PM

This should be submitted to NetBSD so we don't have to maintain a local diff.

contrib/mtree/spec.c
720	To reduce the churn of this patch, I'm tempted to suggest this should be `centryp` and there should be a `NODE centry` that is initialized to `centry`.