Differential D24084

bhyve ahci controller report Nominal Media Rotation Rate field
AbandonedPublic
Actions

Authored by wanpengqian_gmail.com on Mar 16 2020, 1:57 AM.

Details

Reviewers

grehan

Group Reviewers

bhyve

Summary

Currently bhyve will not report this field.

setting nmrr=1 will let ahci controller report disk as Solid State Disk.
other valid value will report as RPM of disk.

ref document:
http://www.t13.org/documents/UploadedDocuments/docs2016/di529r14-ATAATAPI_Command_Set_-_4.pdf

9.11.5.4 NOMINAL MEDIA ROTATION RATE field

Test Plan

Specify the nmrr filed value of 0/1/5400/7200,
check the report value inside Linux/FreeBSD/Windows guests.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29962
Build 27775: arc lint + arc unit

Event Timeline

wanpengqian_gmail.com created this revision.Mar 16 2020, 1:57 AM

Herald added a reviewer: bhyve. · View Herald TranscriptMar 16 2020, 1:57 AM

Herald added subscribers: bcran, rgrimes. · View Herald Transcript

Harbormaster completed remote builds in B29962: Diff 69561.Mar 16 2020, 1:57 AM

wanpengqian_gmail.com added a reviewer: grehan.Mar 16 2020, 2:01 AM

Since this is modification also affect block_if.c, to narrow down the change. this revision is abandoned.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

5 line(s)

1 line

17 line(s)

1 line

Diff 69561

View Options

usr.sbin/bhyve/bhyve.8

View Options

usr.sbin/bhyve/block_if.h

View Options

usr.sbin/bhyve/block_if.c

View Options

bhyve ahci controller report Nominal Media Rotation Rate fieldAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 69561

usr.sbin/bhyve/bhyve.8

usr.sbin/bhyve/block_if.h

usr.sbin/bhyve/block_if.c

usr.sbin/bhyve/pci_ahci.c

bhyve ahci controller report Nominal Media Rotation Rate field
AbandonedPublic
Actions

Revision Contents
Changeset List