Paths

Table of Contentst

Differential D25634

Make linux(4) fail lseek(2) on ttys
Needs ReviewPublic
Actions

Authored by trasz on Jul 12 2020, 2:48 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Summary

Make linux(4) fail lseek(2) on ttys. This fixes one of the Python
tests.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32545
Build 30017: arc lint + arc unit

Event Timeline

trasz created this revision.Jul 12 2020, 2:48 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 12 2020, 2:48 PM

trasz requested review of this revision.Jul 12 2020, 2:48 PM

Harbormaster completed remote builds in B32273: Diff 74355.Jul 12 2020, 2:48 PM

kib added inline comments.Jul 12 2020, 7:37 PM

sys/compat/linux/linux_file.c
251	It is very non-conformant with other parts of the kernel. Normally we check for fp->f_type == DTYPE_VNODE and then just dereference fp->f_vnode. One day f_vnode might be reused for something for !DTYPE_VNODE file types, if not already.

Fix from kib@.

Harbormaster completed remote builds in B32542: Diff 74929.Jul 25 2020, 7:13 PM

trasz marked an inline comment as done.Jul 25 2020, 7:13 PM

Fix suggested by kib@.

Harbormaster completed remote builds in B32543: Diff 74930.Jul 25 2020, 7:16 PM

Sigh, upload the right diff.

Harbormaster completed remote builds in B32545: Diff 74932.Jul 25 2020, 7:19 PM

kib added inline comments.Jul 25 2020, 7:48 PM

sys/compat/linux/linux_file.c
250	`if (fp->f_type != DTYPE_VNODE \|\| (vp = fp->f_vnode)->v_type != VCHR) {`
255	Then drop this line.
260	I would write this as `is_tty = vp->v_rdev != NULL && (vp->v_rdev->si_devsw->d_flags & D_TTY) != 0;`

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

35 line(s)

Diff 74932

sys/compat/linux/linux_file.c

Loading...