Page MenuHomeFreeBSD
Differential D27173

Add regression test for D27164
ClosedPublic
Actions

Authored by jtl on Nov 11 2020, 3:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 29, 2:21 AM
Unknown Object (File)
Fri, Nov 29, 2:21 AM
Unknown Object (File)
Fri, Nov 29, 2:21 AM
Unknown Object (File)
Fri, Nov 29, 2:21 AM
Unknown Object (File)
Fri, Nov 29, 2:21 AM
Unknown Object (File)
Mon, Nov 11, 6:07 AM
Unknown Object (File)
Sun, Nov 10, 7:25 AM
Unknown Object (File)
Fri, Nov 8, 1:01 AM
View All 42 Files
Subscribers
asomers
imp
melifaro

Details

Reviewers
olivier
tuexen
markj
bz
Group Reviewers
transport
Commits
rS367685: Add a regression test for the port-selection behavior fixed in r367680.
Summary

D27164 describes a problem with (and fix for) implicit local port selection as part of the connect() call. This regression test fails for IPv6 without the fix and passes with the fix.

Test Plan

Run the regression test with and without the fix. Verify the test fails without the fix and passes with the fix.

Without the fix:

sys/netinet/tcp_connect_port_test:basic_ipv4  ->  passed  [2.093s]
sys/netinet/tcp_connect_port_test:basic_ipv6  ->  failed: /home/ec2-user/ocafirmware/FreeBSD/tests/sys/netinet/tcp_connect_port_test.c:245: client socket 55535 using the same port as server  [1.972s]

With the fix:

sys/netinet/tcp_connect_port_test:basic_ipv4  ->  passed  [2.109s]
sys/netinet/tcp_connect_port_test:basic_ipv6  ->  passed  [2.486s]

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
head/
tests/
sys/
netinet/
3 lines
334 lines

Diff 79549

View Options

head/tests/sys/netinet/Makefile

Loading...
View Options

head/tests/sys/netinet/tcp_connect_port_test.c

Loading...