devel/tailor: Re-add port and update to 0.9.36
ClosedPublic
Actions

Authored by rhurlin on Dec 12 2020, 7:22 PM.

Details

Reviewers

arrowd
tcberner
portmaster_BSDforge.com

Commits

rP558151: devel/tailor: Re-add port and update to 0.9.36

Summary

Re-add expired port and update from 0.9.35 to 0.9.36. Use Python 3.7+ now.

Submitted by Chris Hutchinson <portmaster@bsdforge.com> (maintainer) in PR 251777.

In addition to the maintainer's patch, there are the following changes:

USES=python:3.7+ instead of python:3.7
Add USE_PYTHON=autoplist and PORTDOCS=README.* instead of pkg-plist
Add files/patch-vcpx_tailor.py to change version

Testet on Poudriere (amd64, i386). 'portlint -AC' is ok.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 35411
Build 32325: arc lint + arc unit

Event Timeline

rhurlin created this revision.Dec 12 2020, 7:22 PM

Herald added a subscriber: mat. · View Herald TranscriptDec 12 2020, 7:22 PM

rhurlin requested review of this revision.Dec 12 2020, 7:22 PM

Harbormaster completed remote builds in B35372: Diff 80642.Dec 12 2020, 7:23 PM

rhurlin edited the summary of this revision. (Show Details)Dec 12 2020, 7:24 PM

LGTM
I'm embarrassed I forgot MOVED, as well as *version* in vcpx_tailor.py.

Thanks for taking the time to do this, Rainer. Really appreciate it.
Sorry for the bother.

This revision is now accepted and ready to land.Dec 12 2020, 8:15 PM

Wait a minute. I should really fix the version in the source itself (vcpx_tailor.py).
Can you pull that patch from this differential, and I'll submit the correct diff to the pr.
Or is there a better way, like make all these proposed changes to the pr this differential references?
Sorry. I have limited experience with these differentials, and the preferred procedure.

@rhurlin make sure you follow https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#ports-qa-resurrect to re-add the port.

In D27590#616551, @portmaster_BSDforge.com wrote:

Wait a minute. I should really fix the version in the source itself (vcpx_tailor.py).
Can you pull that patch from this differential, and I'll submit the correct diff to the pr.

I am not sure, if I understand you right. The complete diff of this review as a raw file is available via differential.

Or is there a better way, like make all these proposed changes to the pr this differential references?

If you will update the version in vcpx/tailor.py, I will create an updated patch for this review. You do not have to do it :)

Sorry. I have limited experience with these differentials, and the preferred procedure.

No problem. It is only necessary to give me an updated download address for your sources of tailor on BSDforge. BTW, is there any changelog for tailor?

In D27590#616552, @tcberner wrote:

@rhurlin make sure you follow https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#ports-qa-resurrect to re-add the port.

@tcberner I thought I followed this article. What exactly is the problem here? Do you mean the addport script (from the tip)? I didn't use it and made all manually.

OK I have a proper diff that makes all the necessary corrections. I went to attach it
to this differential, and submit took me to a different differential. I'm unclear how
anyone gets along here.
I'll try to attach it again.

OK I'm a reasonably intelligent individual. But the software used
for this appears to me to be fairly clueless. In my attempt to
update this differential with a newer diff. It created:
https://reviews.freebsd.org/D27593
Sorry. I simply followed the direction this software took me.

In D27590#616554, @rhurlin wrote:

In D27590#616552, @tcberner wrote:

@rhurlin make sure you follow https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#ports-qa-resurrect to re-add the port.

@tcberner I thought I followed this article. What exactly is the problem here? Do you mean the addport script (from the tip)? I didn't use it and made all manually.