hconf(4): Do not fetch report before writing new usage values back.
ClosedPublic
Actions

Authored by wulf on Jan 16 2021, 8:37 PM.

Details

Reviewers

avg
alvisen_gmail.com

Commits

rGfa656aefe43b: hconf(4): Do not fetch report before writing new usage values back.

Summary

There is a report that reading of surface/button switch feature report
causes SYN1B7D touchpad malfunction. As specs does not require it to
be readable assume that report usages have default value on attach and
last written value during operation.
While here, do not apply default usage values on resume.

Test Plan

Test dev.hmt.*.* sysctls before and after suspend/resume

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wulf requested review of this revision.Jan 16 2021, 8:37 PM

wulf created this revision.

Fix stupid bug leading to setting of old usage value instead of new one.

hconf(4) says dev.hmt where I think it should say dev.hconf:

diff --git a/share/man/man4/hconf.4 b/share/man/man4/hconf.4
index 4d595e9f1c6..a2b50dbb8de 100644

a/share/man/man4/hconf.4

+++ b/share/man/man4/hconf.4
@@ -61,11 +61,11 @@ Debug parameter is available as
.Xr loader 8
tunable as well.
.Bl -tag -width indent
-.It Va dev.hmt.*.input_mode
+.It Va dev.hconf.*.input_mode
HID device input mode: 0 = mouse, 3 = touchpad.
-.It Va dev.hmt.*.surface_switch
+.It Va dev.hconf.*.surface_switch
Enable / disable switch for surface: 1 = on, 0 = off.
-.It Va dev.hmt.*.buttons_switch
+.It Va dev.hconf.*.buttons_switch
Enable / disable switch for buttons: 1 = on, 0 = off.
.It Va hw.hid.hconf.debug
Debug output level, where 0 is debugging disabled and larger values increase