Page MenuHomeFreeBSD

if_awg: build error with DEVICE_POLLING
Needs ReviewPublic

Authored by sigsys_gmail.com on Jan 20 2021, 5:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 1:28 PM
Unknown Object (File)
Thu, Nov 14, 9:03 AM
Unknown Object (File)
Thu, Nov 14, 6:43 AM
Unknown Object (File)
Wed, Nov 13, 12:40 AM
Unknown Object (File)
Dec 20 2023, 6:33 AM
Unknown Object (File)
Dec 13 2023, 6:14 AM
Unknown Object (File)
Nov 23 2023, 11:39 PM
Unknown Object (File)
Nov 20 2023, 6:36 AM
Subscribers

Details

Reviewers
manu
Summary

if_awg won't build with the DEVICE_POLLING option since reorganization in 5fba90649ad564a5820877c7448383847f7f20e8 (r367883) because awg_poll() is used in awg_ioctl() before it is defined/declared.

/usr/src/sys/arm/allwinner/if_awg.c:1152:33: error: use of undeclared identifier 'awg_poll'; did you mean 'awg_ioctl'?
                                error = ether_poll_register(awg_poll, ifp);
                                                            ^~~~~~~~
                                                            awg_ioctl
/usr/src/sys/arm/allwinner/if_awg.c:1106:1: note: 'awg_ioctl' declared here
awg_ioctl(if_t ifp, u_long cmd, caddr_t data)
^

Could just add a prototype, but it might be better to move things around a bit again but I wouldn't know where to put it.

Test Plan

Build with DEVICE_POLLING option.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped