Page MenuHomeFreeBSD
Differential D2950

Add missing DTrace scripts that exist in the source tree to the Makefile for install
ClosedPublic
Actions

Authored by hiren on Jun 30 2015, 2:03 AM.
Tags
Referenced Files
Unknown Object (File)
Thu, Nov 14, 5:43 PM
Unknown Object (File)
Thu, Nov 14, 8:42 AM
Unknown Object (File)
Nov 13 2024, 11:38 AM
Unknown Object (File)
Nov 12 2024, 2:37 AM
Unknown Object (File)
Nov 11 2024, 4:12 AM
Unknown Object (File)
Nov 10 2024, 1:28 PM
Unknown Object (File)
Nov 9 2024, 10:36 PM
Unknown Object (File)
Nov 9 2024, 7:17 PM
View All 84 Files
Subscribers
imp

Details

Reviewers
markj
gnn
j-nitrology.com
Summary

Add the missing sample DTrace scripts that exist in the source tree but are not installed into /usr/share/dtrace
nfsattrstats and siftr

Test Plan

Simply run 'make install' from share/dtrace

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

j-nitrology.com updated this revision to Diff 6565.Jun 30 2015, 2:03 AM
j-nitrology.com retitled this revision from to Add missing DTrace scripts that exist in the source tree to the Makefile for install.
j-nitrology.com updated this object.
j-nitrology.com edited the test plan for this revision. (Show Details)
j-nitrology.com added reviewers: hiren, markj.
Herald added a reviewer: gnn. · View Herald TranscriptJun 30 2015, 2:03 AM
Herald added a subscriber: imp. · View Herald Transcript
hiren accepted this revision.Jun 30 2015, 2:12 AM
hiren edited edge metadata.

SCRIPTS entries were not in alphabetical order so not your fault I guess :-)

This revision is now accepted and ready to land.Jun 30 2015, 2:12 AM
j-nitrology.com updated this revision to Diff 6566.EditedJun 30 2015, 2:27 AM
j-nitrology.com edited edge metadata.

Order SCRIPTS alphabetically.

The fact that they were out of order was not lost on my OCD tendencies.. but I didn't want to get too crazy on my first review ;)

This revision now requires review to proceed.Jun 30 2015, 2:27 AM
hiren accepted this revision.Jun 30 2015, 5:02 AM
hiren edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2015, 5:02 AM
gnn abandoned this revision.Jun 30 2015, 3:21 PM
j-nitrology.com edited edge metadata.Jun 30 2015, 6:07 PM
j-nitrology.com added a project: DTrace.
hiren commandeered this revision.Jun 30 2015, 6:09 PM
hiren reclaimed this revision.
hiren edited reviewers, added: j-nitrology.com; removed: hiren.
markj accepted this revision.Jun 30 2015, 6:14 PM
markj edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2015, 6:14 PM
hiren mentioned this in rS284964: Add missing DTrace scripts that exist in the source tree to the Makefile for.Jun 30 2015, 6:23 PM
hiren closed this revision.Jun 30 2015, 6:25 PM

Fixed in r284964

Revision Contents
Changeset List

PathSize
share/
dtrace/
6 lines

Diff 6566

View Options

share/dtrace/Makefile

Loading...