Page MenuHomeFreeBSD
Differential D30017

libsysdecode vmprot should accept underscores in bit names
ClosedPublic
Actions

Authored by freebsdphab-AX9_cmx.ietfng.org on Apr 27 2021, 11:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 8:33 AM
Unknown Object (File)
Fri, Nov 15, 8:49 AM
Unknown Object (File)
Wed, Nov 13, 11:29 PM
Unknown Object (File)
Mon, Nov 11, 5:11 PM
Unknown Object (File)
Mon, Nov 11, 12:11 PM
Unknown Object (File)
Mon, Nov 11, 9:52 AM
Unknown Object (File)
Mar 22 2024, 11:11 PM
Unknown Object (File)
Mar 22 2024, 11:11 PM
View All 42 Files
Subscribers
jhb

Details

Reviewers
jhb
Commits
rG701a99939fbf: libsysdecode: Permit _ in VM_PROT_(.*) names.
Summary

In CheriBSD, we've defined VM_PROT_WRITE_CAP, for example, and these are currently rejected by the libsysdecode mktables regex, and so are not printed by name but just left as unexplained set bits.

Test Plan

ktrace and kdump a CheriABI executable, verifying that the new flags are decoded correctly

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

freebsdphab-AX9_cmx.ietfng.org requested review of this revision.Apr 27 2021, 11:22 PM
freebsdphab-AX9_cmx.ietfng.org created this revision.
jhb accepted this revision.Apr 28 2021, 3:24 PM
jhb added a subscriber: jhb.

I tended to use fairly conservative regexes in mktables, but this is ok with me.

This revision is now accepted and ready to land.Apr 28 2021, 3:24 PM
Closed by commit rG701a99939fbf: libsysdecode: Permit _ in VM_PROT_(.*) names. (authored by nfilardo_microsoft.com, committed by jhb). · Explain WhySep 24 2021, 12:33 AM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG701a99939fbf: libsysdecode: Permit _ in VM_PROT_(.*) names..

Revision Contents
Changeset List

PathSize
lib/
libsysdecode/
2 lines

Diff 95595

View Options

lib/libsysdecode/mktables

Loading...