qlnxe: Fix a use-after-free in ecore_spq_post()
Needs ReviewPublic
Actions

Authored by markj on Jun 2 2021, 2:10 PM.

Details

Reviewers

Summary

ecore_sqp_add_entry() may free the spq entry structure. Then,
ecore_spq_post() may dereference the entry to check
p_ent->comp_mode == ECORE_SPQ_MODE_EBLOCK.

Fix the problem by changing ecore_sqp_add_entry() to return the new
entry pointer.

PR: 255868
MFC after: 1 week

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39663
Build 36552: arc lint + arc unit

Event Timeline

markj created this revision.Jun 2 2021, 2:10 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 2 2021, 2:10 PM

markj requested review of this revision.Jun 2 2021, 2:10 PM

Harbormaster completed remote builds in B39663: Diff 90321.Jun 2 2021, 2:10 PM

emaste subscribed.Jun 2 2021, 10:43 PM

info_dominicschlegel.ch subscribed.Oct 21 2021, 9:44 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

qlnx/

qlnxe/

ecore_spq.c

12 line(s)

Diff 90321

View Options

sys/dev/qlnx/qlnxe/ecore_spq.c

qlnxe: Fix a use-after-free in ecore_spq_post()Needs ReviewPublicActions