Differential D31951

powerpc64: change CAS to support Radix MMU
ClosedPublic
Actions

Authored by luporl on Sep 13 2021, 6:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 17, 1:12 AM

	Unknown Object (File)
	Wed, Nov 13, 9:18 AM

	Unknown Object (File)
	Tue, Nov 12, 1:56 PM

	Unknown Object (File)
	Mon, Nov 11, 6:29 PM

	Unknown Object (File)
	Mon, Nov 11, 5:57 PM

	Unknown Object (File)
	Sun, Nov 10, 1:26 PM

	Unknown Object (File)
	Sun, Nov 10, 6:28 AM

	Unknown Object (File)
	Sun, Nov 10, 2:29 AM

View All 65 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGcc8e726c85be: powerpc64: change CAS to support Radix MMU
rGa58abcde2c83: powerpc64: change CAS to support Radix MMU

Summary

Use radix_mmu environment variable to select between Hash or Radix MMU, when performing the CAS method call.

This matches kernel's behavior, by selecting Hash MMU by default and Radix if radix_mmu is not zero, to make sure that both loader and kernel always select the same MMU.

If the detected CPU is not a POWER9, then Hash MMU is selected, regardless of radix_mmu value, as in kernel.

Test Plan

Tested on QEMU pseries with KVM, selecting both Hash and Radix MMUs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

luporl created this revision.Sep 13 2021, 6:53 PM

Herald added subscribers: dab, imp. · View Herald TranscriptSep 13 2021, 6:53 PM

luporl requested review of this revision.Sep 13 2021, 6:53 PM

Harbormaster completed remote builds in B41505: Diff 95077.Sep 13 2021, 6:53 PM

jhibbits added inline comments.Sep 13 2021, 10:21 PM

stand/powerpc/ofw/cas.c
240	Defaulting off for radix_mmu, even on power9?

luporl added inline comments.Sep 14 2021, 11:39 AM

stand/powerpc/ofw/cas.c
240	Yes, we are holding making radix default because of D31232. BTW, do you think it is ok to commit it already? When it lands, there is already D30797 to make radix default. Then we can just get back here and make it default in loader too.

jhibbits accepted this revision.Sep 14 2021, 2:00 PM

jhibbits added inline comments.

stand/powerpc/ofw/cas.c
240	That's all I wanted to know, thanks!

This revision is now accepted and ready to land.Sep 14 2021, 2:00 PM

Query device tree for Radix/GTSE support, instead of using CPU version and HV bit checks, as this is a better approach, as discussed in IRC.

This revision now requires review to proceed.Sep 15 2021, 2:43 PM

Harbormaster completed remote builds in B41525: Diff 95197.Sep 15 2021, 2:43 PM

Add missing break

Harbormaster completed remote builds in B41526: Diff 95198.Sep 15 2021, 2:48 PM

jhibbits added inline comments.Sep 15 2021, 4:01 PM

stand/powerpc/ofw/cas.c
32–33	Why not make this a #ifdef instead?

Address reviewer's comments

Harbormaster completed remote builds in B41531: Diff 95219.Sep 15 2021, 5:06 PM

luporl marked an inline comment as done.Sep 15 2021, 5:06 PM

luporl added inline comments.

stand/powerpc/ofw/cas.c
32–33	Ok, I've used #if just because it's a bit less typing to enable/disable it.

luporl marked an inline comment as done.Sep 15 2021, 5:06 PM

luporl marked an inline comment as done.

jhibbits accepted this revision.Sep 15 2021, 5:48 PM

This revision is now accepted and ready to land.Sep 15 2021, 5:48 PM

Don't forget to update the commit message, with the latest changes you made.

Closed by commit rGa58abcde2c83: powerpc64: change CAS to support Radix MMU (authored by luporl). · Explain WhySep 15 2021, 6:26 PM

This revision was automatically updated to reflect the committed changes.

luporl added a commit: rGa58abcde2c83: powerpc64: change CAS to support Radix MMU.

luporl added a commit: rGcc8e726c85be: powerpc64: change CAS to support Radix MMU.Sep 30 2021, 11:35 AM

Revision Contents
Changeset List

Path

Size

stand/

powerpc/

ofw/

120 lines

Diff 95221

stand/powerpc/ofw/cas.c

Loading...