Differential D33785

Add unit test for ggate flush
Needs ReviewPublic
Actions

Authored by jo_bruelltuete.com on Jan 8 2022, 2:23 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

asomers
peterj

Summary

Add a test case for flush in ggate.

And while here fix the problem it uncovers.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jo_bruelltuete.com created this revision.Jan 8 2022, 2:23 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 8 2022, 2:23 AM

jo_bruelltuete.com requested review of this revision.Jan 8 2022, 2:23 AM

jo_bruelltuete.com added inline comments.Jan 8 2022, 2:26 AM

sbin/ggate/ggated/ggated.c
753	fsync() doesn't actually result in any flushes... but i suppose we want both here? any opinions?
tests/sys/geom/class/gate/ggate_test.sh
30	how to trigger a bio_flush from user mode? zpool works. none of the fsync or dd with conv=fsync do, however.
39	cleanup is not great... the cleanup() functions here are never called when i try to run this script.

jo_bruelltuete.com planned changes to this revision.Jan 9 2022, 12:52 AM

jo_bruelltuete.com added inline comments.

tests/sys/geom/class/gate/ggate_test.sh
223	no, bad idea... this breaks the tests (they no longer fail on failure)

jo_bruelltuete.com updated this revision to Diff 101154.Jan 9 2022, 2:17 AM

jo_bruelltuete.com added inline comments.Jan 9 2022, 2:20 AM

tests/sys/geom/class/gate/ggate_test.sh
37	this way around the test will only pass if numflushes has a number in it.
186	fill the whole device
232	64m is minimum pool size.

jo_bruelltuete.com added a reviewer: peterj.Jan 28 2022, 12:18 AM

Revision Contents
Changeset List

Path

Size

sbin/

ggate/

ggated/

2 line(s)

4 line(s)

tests/

sys/

geom/

class/

gate/

65 line(s)

Diff 101154

sbin/ggate/ggated/Makefile

Loading...

sbin/ggate/ggated/ggated.c

Loading...

tests/sys/geom/class/gate/ggate_test.sh

Loading...