Page MenuHomeFreeBSD

zdiff: avoid non-conformant features
ClosedPublic

Authored by kevans on May 20 2022, 8:47 PM.
Tags
None
Referenced Files
F81876215: D35275.id106226.diff
Mon, Nov 25, 4:59 AM
F81876214: D35275.id106226.diff
Mon, Nov 25, 4:59 AM
F81875124: D35275.diff
Sun, Nov 24, 10:04 PM
Unknown Object (File)
Mon, Nov 11, 7:50 PM
Unknown Object (File)
Mon, Nov 11, 1:09 AM
Unknown Object (File)
Mon, Nov 11, 12:52 AM
Unknown Object (File)
Mon, Nov 11, 12:31 AM
Unknown Object (File)
Sun, Nov 10, 3:20 PM
Subscribers

Details

Summary

setvar is a non-conformant feature that looks slightly neater but is
not portable to other /bin/sh implementations. Making the script
portable is straightforward, so let's do it.

Tests are added to make sure that I didn't break anything major in the
process.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 21 2022, 12:27 PM
jilles requested changes to this revision.May 21 2022, 1:36 PM
jilles added inline comments.
usr.bin/gzip/zdiff
41–42

This used to work with filenames containing ", ` and $ but no longer does. Likewise for all other eval "$2= below.

This revision now requires changes to proceed.May 21 2022, 1:36 PM
kevans marked an inline comment as done.

Fix files containing ", `, and $. Add tests to cover those names, as well, for
all of these cases.

This revision is now accepted and ready to land.May 26 2022, 4:35 PM
This revision was automatically updated to reflect the committed changes.