sysutils/polkit: Update to 121
AbandonedPublic
Actions

Authored by duchateau.olivier_gmail.com on Jul 15 2022, 9:18 AM.

Details

Reviewers

None

Group Reviewers

desktop

Summary

Update to 121
Remove Created to: header
Add SPIDERMONKEY (set by default) and DUKTAPE options
Remove unneeded patch

Note: Most Linux distribution and OpenBSD switched to Duktape, in the port we still depend of SpiderMonkey (I don't know which one is better).

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

duchateau.olivier_gmail.com requested review of this revision.Jul 15 2022, 9:18 AM

duchateau.olivier_gmail.com created this revision.

I would suggest to make Duktape the default, as it is also intended as such by upstream.

vishwin mentioned this in D34188: sysutils/polkit: add duktape support.Jul 15 2022, 12:52 PM

I was dogfooding duktape in D34188, but even to this day trying to run say pkexec results in a crash. Perhaps things have improved with this new release (finally) but duktape support needs more testing on our platform before it can be considered the default.

Update diff:

Switch by default to Duktape, tested with desktop environment (Pantheon) which has polkit agent and with Xfce (there is no polkit agent) → no crash
Remove redundant _GNU_SOURCE (I wonder if it is important, because it is not available on FreeBSD)
Add support of procctl(2) in pkexec program

Below options enable for sysutils/polkit

make showconfig
===> The following configuration options are available for polkit-121:
     MANPAGES=off: Build and/or install manual pages
====> JavaScript engines: you have to select exactly one of them
     DUKTAPE=on: Duktape JavaScript backend
     SPIDERMONKEY=off: SpiderMonkey JavaScript backend
===> Use 'make config' to modify these settings

duchateau.olivier_gmail.com mentioned this in D37137: sysutils/polkit: Update to 122.Oct 26 2022, 5:59 PM

duchateau.olivier_gmail.com mentioned this in D37224: Add Budgie desktop.Oct 31 2022, 4:08 PM

Should this be closed? The port is of version 122 already.

duchateau.olivier_gmail.com abandoned this revision.Feb 5 2023, 7:29 PM