Page MenuHomeFreeBSD
Differential D35876

sh: nullify ENV in tests
ClosedPublic
Actions

Authored by pstef on Jul 21 2022, 6:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 8:40 AM
Unknown Object (File)
Tue, Nov 12, 9:24 PM
Unknown Object (File)
Tue, Nov 12, 8:12 PM
Unknown Object (File)
Tue, Nov 12, 12:10 PM
Unknown Object (File)
Mon, Nov 11, 7:49 AM
Unknown Object (File)
Sun, Nov 10, 2:16 PM
Unknown Object (File)
Sat, Nov 9, 10:46 PM
Unknown Object (File)
Sat, Nov 9, 9:22 PM
View All 33 Files
Subscribers
imp

Details

Reviewers
jilles
Commits
rGa1423456415a: sh: nullify ENV in tests
Summary

This is to avoid loading .shrc which may contain commands that would result in output different than expected.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pstef created this revision.Jul 21 2022, 6:45 PM
Herald added a reviewer: jilles. · View Herald TranscriptJul 21 2022, 6:45 PM
Herald added a subscriber: imp. · View Herald Transcript
pstef requested review of this revision.Jul 21 2022, 6:45 PM
jilles accepted this revision.Jul 22 2022, 8:47 AM

Thanks, I have also encountered this issue.

Perhaps this approach, adding ENV= before $SH -i uses in test scripts, is best since it supports running single test scripts without any wrapping. There are not that many test scripts that use interactive mode.

This revision is now accepted and ready to land.Jul 22 2022, 8:47 AM
Closed by commit rGa1423456415a: sh: nullify ENV in tests (authored by pstef). · Explain WhyAug 20 2022, 11:31 AM
This revision was automatically updated to reflect the committed changes.
pstef added a commit: rGa1423456415a: sh: nullify ENV in tests.

Revision Contents
Changeset List

PathSize
bin/
sh/
tests/
builtins/
2 lines
2 lines
execution/
2 lines

Diff 109598

View Options

bin/sh/tests/builtins/cd10.0

Loading...
View Options

bin/sh/tests/builtins/fc1.0

Loading...
View Options

bin/sh/tests/execution/int-cmd1.0

Loading...