ast_sig(): add missed TDAI()
ClosedPublic
Actions

Authored by kib on Aug 3 2022, 1:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 14, 1:57 PM

	Unknown Object (File)
	Thu, Nov 14, 9:14 AM

	Unknown Object (File)
	Thu, Nov 14, 2:47 AM

	Unknown Object (File)
	Tue, Nov 12, 2:40 AM

	Unknown Object (File)
	Mon, Nov 11, 3:51 PM

	Unknown Object (File)
	Dec 20 2023, 3:31 AM

	Unknown Object (File)
	Dec 13 2023, 6:14 AM

	Unknown Object (File)
	Nov 15 2023, 7:37 AM

View All 28 Files

Subscribers

imp

sigsys_gmail.com

Details

Reviewers

markj

Commits

rGc53fec76033a: sig_suspend_threads(): remove 'sending' arg
rGf2fd7d8bfc69: ast_sig(): add missed TDAI()

Summary

Mask checked was completely wrong

Also the cleanup:

sig_suspend_threads(): remove 'sending' arg

The TDA_AST flag is set on td2 unconditionally (as it was TDF_ASTPENDING
before AST rework), so it is not used practically for some time.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Aug 3 2022, 1:47 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 3 2022, 1:47 PM

kib requested review of this revision.Aug 3 2022, 1:47 PM

markj accepted this revision.Aug 3 2022, 1:54 PM

This revision is now accepted and ready to land.Aug 3 2022, 1:54 PM

kib added a subscriber: sigsys_gmail.com.Aug 3 2022, 1:54 PM

Closed by commit rGf2fd7d8bfc69: ast_sig(): add missed TDAI() (authored by kib). · Explain WhyAug 3 2022, 1:56 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGf2fd7d8bfc69: ast_sig(): add missed TDAI().

kib added a commit: rGc53fec76033a: sig_suspend_threads(): remove 'sending' arg.

I don't understand much of it, but I can confirm that the last commits fixed the problem I noticed with signals sent in syscallret().

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_sig.c

2 lines

Diff 108853

View Options

ast_sig(): add missed TDAI()ClosedPublicActions