Page MenuHomeFreeBSD
Differential D3719

Add support for sysctl knobs to live tune the per interrupt rx/tx packet processing limits in ixgbe(4)
ClosedPublic
Actions

Authored by j-nitrology.com on Sep 23 2015, 7:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 9:38 AM
Unknown Object (File)
Fri, Nov 15, 7:04 PM
Unknown Object (File)
Fri, Nov 15, 11:54 AM
Unknown Object (File)
Thu, Nov 14, 1:26 AM
Unknown Object (File)
Nov 11 2024, 3:37 AM
Unknown Object (File)
Nov 11 2024, 3:36 AM
Unknown Object (File)
Nov 9 2024, 12:29 PM
Unknown Object (File)
Nov 9 2024, 8:46 AM
View All Files
Subscribers
imp
kbowling

Details

Reviewers
erj
sbruno
Group Reviewers
Intel Networking
Summary

Currently you can only set the packet processing limits via boot only tunables under hw.ix, this adds per adapter limits that allow live tuning

Test Plan

Verified the new sysctls inherit the default or the boot time setting, and that changing them affects the next run of rxeof()/txeof()

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 589
Build 589: arc lint + arc unit

Event Timeline

j-nitrology.com updated this revision to Diff 8903.Sep 23 2015, 7:54 AM
j-nitrology.com retitled this revision from to Add support for sysctl knobs to live tune the per interrupt rx/tx packet processing limits in ixgbe(4).
j-nitrology.com updated this object.
j-nitrology.com edited the test plan for this revision. (Show Details)
j-nitrology.com added reviewers: hiren, sbruno.
Herald added a reviewer: Intel Networking. · View Herald TranscriptSep 23 2015, 7:54 AM
Herald added a subscriber: imp. · View Herald Transcript
j-nitrology.com updated this revision to Diff 8905.Sep 23 2015, 9:01 AM
j-nitrology.com edited edge metadata.

Clean up now unused old process_limits, we use the ones in the adapter struct for all limits in the rx/tx task queues.

Herald edited edge metadata. · View Herald TranscriptSep 23 2015, 9:01 AM
sbruno accepted this revision.Sep 23 2015, 4:01 PM
sbruno edited edge metadata.
This revision is now accepted and ready to land.Sep 23 2015, 4:01 PM
kbowling added a subscriber: kbowling.Sep 23 2015, 10:54 PM
j-nitrology.com edited the test plan for this revision. (Show Details)Sep 24 2015, 5:49 PM
j-nitrology.com added a reviewer: erj.
hiren resigned from this revision.Sep 24 2015, 6:04 PM
hiren removed a reviewer: hiren.

Looks okay to me except the ix_txrx.c change of exposing struct adapter.

I'll let Sean/Eric have a final say.

Good work, Jason!

sbruno closed this revision.Oct 13 2015, 5:35 PM

Committed revision 289238.

Revision Contents
Changeset List

PathSize
sys/
dev/
ixgbe/
27 lines
27 lines
6 lines
4 lines

Diff 8905

View Options

sys/dev/ixgbe/if_ix.c

Loading...
View Options

sys/dev/ixgbe/if_ixv.c

Loading...
View Options

sys/dev/ixgbe/ix_txrx.c

Loading...
View Options

sys/dev/ixgbe/ixgbe.h

Loading...