Differential D40304

Refactor tcp_get_srtt()
ClosedPublic
Actions

Authored by jtl on May 27 2023, 3:06 PM.

Tags

None

Referenced Files

	F81887341: D40304.id122516.diff
	Thu, Nov 28, 12:03 PM

	Unknown Object (File)
	Sun, Nov 17, 5:21 PM

	Unknown Object (File)
	Sat, Nov 16, 5:46 PM

	Unknown Object (File)
	Tue, Nov 12, 9:31 AM

	Unknown Object (File)
	Thu, Nov 7, 7:04 PM

	Unknown Object (File)
	Thu, Nov 7, 6:34 PM

	Unknown Object (File)
	Thu, Nov 7, 4:19 PM

	Unknown Object (File)
	Thu, Nov 7, 3:56 PM

View All 33 Files

Subscribers

Details

Reviewers

rrs
lstewart
cc
tuexen

Group Reviewers

Commits

rG4f2cc73f34eb: tcp: Refactor tcp_get_srtt()

Summary

After rGf5abdb03119a, it looks like there is an opportunity to refactor tcp_get_srtt() into its two component operations: unit conversion and shifting.

This should not cause any functional change.

Note for the future: I question whether it is a good idea for the long-term to manage the complexity of maintaining alternate unit storage in the TCB. If there is not already a plan for unifying the unit used for these values, I think we should consider making one.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jtl created this revision.May 27 2023, 3:06 PM

Herald added a reviewer: transport. · View Herald TranscriptMay 27 2023, 3:06 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

jtl requested review of this revision.May 27 2023, 3:06 PM

There is the plan to move the base stack away from ticks and use usecs everywhere. But we wanted not to do this before stable/14 is branched.

This revision is now accepted and ready to land.May 27 2023, 7:01 PM

cc accepted this revision.May 27 2023, 9:33 PM

Closed by commit rG4f2cc73f34eb: tcp: Refactor tcp_get_srtt() (authored by jtl). · Explain WhyMay 31 2023, 7:24 PM

This revision was automatically updated to reflect the committed changes.

jtl added a commit: rG4f2cc73f34eb: tcp: Refactor tcp_get_srtt().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

49 lines

Diff 122678

sys/netinet/tcp_subr.c

Loading...