Differential D42747

pf: fix mem leaks upon vnet destroy
ClosedPublic
Actions

Authored by igor.ostapenko_pm.me on Nov 24 2023, 1:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 12, 9:39 PM

	Unknown Object (File)
	Tue, Nov 12, 6:19 PM

	Unknown Object (File)
	Mon, Nov 11, 5:49 PM

	Unknown Object (File)
	Mon, Nov 11, 3:54 PM

	Unknown Object (File)
	Mon, Nov 11, 5:49 AM

	Unknown Object (File)
	Mon, Nov 11, 12:59 AM

	Unknown Object (File)
	Sun, Nov 10, 6:08 PM

	Unknown Object (File)
	Sun, Nov 10, 7:21 AM

View All 19 Files

Subscribers

Details

Reviewers

kp
thj

Group Reviewers

Commits

rG285b505a4ee0: pf: fix mem leaks upon vnet destroy
rG05c55eed44e5: pf: fix mem leaks upon vnet destroy
rG0626d30e41cb: pf: fix mem leaks upon vnet destroy

Summary

It adds missing cleanup actions:
- remove user defined anchor rulesets
- remove user defined ether anchor rulesets
- remove tables linked to user defined anchors
- deal with wildcard anchor peculiarities to get them removed correctly

PR:             274310

Test Plan

Tom's shell script reports whether such mem leaks are present or not. It's attached to 274310.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

igor.ostapenko_pm.me created this revision.Nov 24 2023, 1:01 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptNov 24 2023, 1:01 PM

igor.ostapenko_pm.me requested review of this revision.Nov 24 2023, 1:01 PM

kp added inline comments.Nov 28 2023, 12:31 PM

sys/netpfil/pf/pf_ioctl.c
6247	Let's assert this.
6267	Let's assert that this succeeds.

The assertions have been added.
This update also proposes to apply the same assertion for the main two anchors (existing code).

igor.ostapenko_pm.me marked 2 inline comments as done.Nov 28 2023, 2:11 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2023, 6:06 PM

Closed by commit rG0626d30e41cb: pf: fix mem leaks upon vnet destroy (authored by igor.ostapenko_pm.me, committed by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG0626d30e41cb: pf: fix mem leaks upon vnet destroy.

kp added a commit: rG05c55eed44e5: pf: fix mem leaks upon vnet destroy.Dec 6 2023, 2:41 PM

kp added a commit: rG285b505a4ee0: pf: fix mem leaks upon vnet destroy.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

67 lines

Diff 130795

sys/netpfil/pf/pf_ioctl.c

Loading...