Details
Details
- Reviewers
- None
- Group Reviewers
secteam
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| FreeBSD-EN-23:17.ossl | ||
|---|---|---|
| 21 | Does not need to be wrapped at so few cols -- you can use 77 cols as in the ====== at the top | |
| 22 | Splitting into two sentences improves clarity IMO - "...derived from OpenSSL. It is integrated..." | |
| 28 | did not properly, were not thread-safe etc.? | |
| 50–52 | Might want to have a brief comment about why ossl exists, given this last sentence. | |
| 56 | delete | |
| 60 | I guess for this one it is really "reboot if running a custom kernel with ossl built-in, or unload and reload the ossl kernel module"? Although perhaps it is fine to always document a reboot for kernel issues. | |
| 82–85 | Remove 12.4, add patch details | |
| FreeBSD-EN-23:17.ossl | ||
|---|---|---|
| 82–85 | It's there as a sample for the case where there are different patches per release, e.g.: [FreeBSD 14.0] # fetch ... bug.14.patch ... [FreeBSD 13.2] # fetcch ... bug.13.patch ... # gpg -verfiy bug.13.patch.asc If the same patch applies to all affected releases (or there's only one) it can be omitted. | |