Page MenuHomeFreeBSD
Differential D43479

arm64: fix db_read_bytes() for size == 8
ClosedPublic
Actions

Authored by mhorne on Jan 17 2024, 4:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 8:35 PM
Unknown Object (File)
Apr 6 2024, 10:34 PM
Unknown Object (File)
Apr 6 2024, 1:05 PM
Unknown Object (File)
Mar 26 2024, 11:20 PM
Unknown Object (File)
Feb 28 2024, 9:47 PM
Unknown Object (File)
Jan 22 2024, 5:51 AM
Unknown Object (File)
Jan 19 2024, 4:43 AM
Unknown Object (File)
Jan 18 2024, 6:49 PM
Subscribers
emaste
imp

Details

Reviewers
jhb
andrew
dfr
manu
mmel
emaste
Commits
rG4057fb12a1d7: arm64: fix db_read_bytes() for size == 8
rGc738eac52e05: arm64: fix db_read_bytes() for size == 8
rG9c2e1a54f71a: arm64: fix db_read_bytes() for size == 8
Summary

There is a mistake in the cast, resulting in a truncated read to tmp64.

Reported by: dfr
PR: 276406

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.Jan 17 2024, 4:51 PM
Herald added a reviewer: manu. · View Herald TranscriptJan 17 2024, 4:51 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
mhorne requested review of this revision.Jan 17 2024, 4:51 PM
Harbormaster completed remote builds in B55465: Diff 132878.Jan 17 2024, 4:51 PM
mhorne updated this revision to Diff 132879.Jan 17 2024, 5:06 PM

On a second look, the native-sized reads were not an optimization but rather to enable reading from device memory, per a67687fcd8f53.

So, just fix the cast.

Harbormaster completed remote builds in B55466: Diff 132879.Jan 17 2024, 5:06 PM
mhorne added a reviewer: mmel.Jan 17 2024, 5:06 PM
mhorne edited the summary of this revision. (Show Details)
dfr accepted this revision.Jan 17 2024, 5:14 PM

Looks good, thanks!

This revision is now accepted and ready to land.Jan 17 2024, 5:14 PM
mmel accepted this revision.Jan 17 2024, 5:17 PM

Thanks fixing my bugs..

emaste accepted this revision.Jan 17 2024, 5:19 PM

Seems like there ought to be a comment before the if size == 8 / else if / else if block.

jhb accepted this revision.Jan 17 2024, 6:22 PM
jhb added inline comments.
sys/arm64/arm64/db_interface.c
134

I think const uint64_t * would be clearer here, and similarly for the other casts below.

Closed by commit rG9c2e1a54f71a: arm64: fix db_read_bytes() for size == 8 (authored by mhorne). · Explain WhyJan 18 2024, 5:23 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG9c2e1a54f71a: arm64: fix db_read_bytes() for size == 8.
mhorne added a commit: rGc738eac52e05: arm64: fix db_read_bytes() for size == 8.Jan 22 2024, 6:05 PM
mhorne added a commit: rG4057fb12a1d7: arm64: fix db_read_bytes() for size == 8.Jan 22 2024, 6:07 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
12 lines

Diff 132940

View Options

sys/arm64/arm64/db_interface.c

Loading...