rtld-elf: report cause of failure to load the hints file
AbandonedPublic
Actions

Authored by se on Feb 25 2024, 5:04 PM.

Details

Reviewers

Summary

A comment to the changes in review D44053 suggested to add specific debug messages for the causes of a failure to load the hints file.
Since these extended debug messages are independent of the the proposed changes in D44053, they have been extracted from that review.
Debug messages are enabled at run time by setting LD_DEBUG to a non-empty string (unless rtld-elf has been compiled with -D NO_LD_DEBUG).

Test Plan

Verify that ld-elf.so.1 can be built with this patch applied and that it is functional.
It is possible to trigger each of the messages by removal, truncation, or modification of the hints file.
Check that the messages correspond to the respective error situations and assess whether each particular message is useful.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

se created this revision.Feb 25 2024, 5:04 PM

Herald added subscribers: bdragon, imp. · View Herald TranscriptFeb 25 2024, 5:04 PM

se requested review of this revision.Feb 25 2024, 5:04 PM

kib accepted this revision.Feb 25 2024, 8:41 PM

kib added inline comments.

libexec/rtld-elf/rtld.c
2102	You could use %#08x, as format specifier, then it is obvious for reader that magic numbers are hex.

This revision is now accepted and ready to land.Feb 25 2024, 8:41 PM

Building in the source directory had worked, but some type casts are required to make some dbg() calls compile during make world.

This revision now requires review to proceed.Feb 25 2024, 9:40 PM

Please upload the full context for the diff (git diff -U99999999 ...)

libexec/rtld-elf/rtld.c
2135	this is usually and better handled with "%jx" and cast to uintmax_t

domagoj.stolfa_gmail.com added a subscriber: domagoj.stolfa_gmail.com.Feb 26 2024, 6:12 PM

domagoj.stolfa_gmail.com added inline comments.

libexec/rtld-elf/rtld.c
2111	This should probably say `"... list is too long: ..."` as opposed to `"list to long"`

Updated according to review comments.

se marked 3 inline comments as done.Feb 26 2024, 9:57 PM

se added inline comments.

libexec/rtld-elf/rtld.c
2102	I'll change the format as suggested.
2135	I had to change the format to %lld and add a cast to get this statement to compile as part of make world. I did not try a make universe with this change.