daemon(8): handle case of waitpid() returning without exited child
ClosedPublic
Actions

Authored by kib on Mar 18 2024, 8:49 AM.

Details

Reviewers

kevans

Commits

rG8eaa6be80d6a: daemon(8): handle case of waitpid() returning without exited child

Summary

Not checking for either WIFEXITED(status) or zero result results in never finishing the loop.

PR: 277764

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Mar 18 2024, 8:49 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 18 2024, 8:49 AM

kib requested review of this revision.Mar 18 2024, 8:49 AM

kevans accepted this revision.Mar 18 2024, 2:41 PM

This revision is now accepted and ready to land.Mar 18 2024, 2:41 PM

Oh, return () style differs here

tamelingdaniel_gmail.com added a subscriber: tamelingdaniel_gmail.com.Mar 18 2024, 3:19 PM

tamelingdaniel_gmail.com added inline comments.

usr.sbin/daemon/daemon.c
767	I think you also need to check WIFSIGNALED(status). Otherwise daemon will not finish when the child is killed by a signal.

Check for WIFSIGNALLED.
Un-style return.

This revision now requires review to proceed.Mar 18 2024, 6:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 20 2024, 1:07 AM

Closed by commit rG8eaa6be80d6a: daemon(8): handle case of waitpid() returning without exited child (authored by kib). · Explain Why

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG8eaa6be80d6a: daemon(8): handle case of waitpid() returning without exited child.

Revision Contents
Changeset List

Path

Size

usr.sbin/

daemon/

daemon.c

14 lines

Diff 135982

View Options

daemon(8): handle case of waitpid() returning without exited childClosedPublicActions