Paths

Table of Contentst

Differential D44667

vm_reserv_reclaim_contig: Return NULL not false
Needs ReviewPublic
Actions

Authored by minsoochoo0122_proton.me on Apr 7 2024, 5:44 AM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Nov 22, 8:44 AM

	Unknown Object (File)
	Fri, Nov 22, 8:36 AM

	Unknown Object (File)
	Fri, Nov 22, 12:14 AM

	Unknown Object (File)
	Apr 10 2024, 2:17 AM

	Unknown Object (File)
	Apr 7 2024, 12:28 PM

Subscribers

Contributor Reviews (src)

Details

Reviewers

Group Reviewers

Contributor Reviews (src)

Summary

Since vm_page_t is a typedef of a pointer to struct vm_page, returning
false is undefined.

Test Plan

make buildkernel

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56953
Build 53841: arc lint + arc unit

Event Timeline

minsoochoo0122_proton.me created this revision.Apr 7 2024, 5:44 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 7 2024, 5:44 AM

minsoochoo0122_proton.me requested review of this revision.Apr 7 2024, 5:44 AM

Harbormaster completed remote builds in B56953: Diff 136640.Apr 7 2024, 5:44 AM

minsoochoo0122_proton.me edited the test plan for this revision. (Show Details)Apr 7 2024, 5:45 AM

minsoochoo0122_proton.me added a reviewer: Contributor Reviews (src).

minsoochoo0122_proton.me added a project: Contributor Reviews (src).

minsoochoo0122_proton.me added a subscriber: Contributor Reviews (src).

I'm not completely familar with FreeBSD's virtual memory system. But it seems the comment still doesn't match the code. Doesn't it return m_ret when the reclaim is successful and null when failed?

lwhsu added a reviewer: markj.Apr 7 2024, 6:10 AM

Revision Contents
Changeset List

Path

Size

sys/

vm/

4 lines

Diff 136640

sys/vm/vm_reserv.c

Loading...