Paths

Table of Contentst

Differential D49067

lindebugfs: Add `debugfs_create_str()`
ClosedPublic
Actions

Authored by dumbbell on Feb 19 2025, 9:33 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bz
emaste

Group Reviewers

Commits

rG78e25e65bf38: lindebugfs: Add `debugfs_create_str()`

Summary

This function is used by the i915 DRM driver starting with Linux 6.8.

This is part of the update of DRM drivers to Linux 6.8.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dumbbell created this revision.Feb 19 2025, 9:33 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptFeb 19 2025, 9:33 PM

dumbbell requested review of this revision.Feb 19 2025, 9:33 PM

bz requested changes to this revision.Feb 22 2025, 1:10 PM

bz subscribed.

bz added inline comments.

sys/compat/lindebugfs/lindebugfs.c
645	To my understanding this is not going to work. simple_attr_read uses a 24 byte buffer. That's going to overflow for (assumed) most strings. Also the default write routine will try to convert the string to a number using strtoq in the end.

This revision now requires changes to proceed.Feb 22 2025, 1:10 PM

dumbbell added inline comments.Feb 22 2025, 6:12 PM

sys/compat/lindebugfs/lindebugfs.c
645	You are right, I didn’t look at the implementation of `DEFINE_DEBUGFS_ATTRIBUTE()` and assumed something more involved :-) I will rework the patch.

Reimplement patch entirely

It depends on D49374.

dumbbell retitled this revision from lindebugfs: Add `debugfs_str_get()` to lindebugfs: Add `debugfs_create_str()`.Mar 15 2025, 11:39 AM

dumbbell edited the summary of this revision. (Show Details)

bz requested changes to this revision.Apr 2 2025, 4:29 PM

bz added inline comments.

sys/compat/lindebugfs/lindebugfs.c
703	This seems wrong. Should it be old_len + write_size or simply new_len?

This revision now requires changes to proceed.Apr 2 2025, 4:29 PM

debugfs_create_str needs to be added to the export list in sys/modules/lindebugfs/Makefile (see rG:516adf364cabe7d840129a12c71434793739dc81)

emaste requested changes to this revision.Apr 8 2025, 9:34 PM

Address feedback from @bz and @emaste.

dumbbell marked an inline comment as done.Apr 12 2025, 10:28 AM

bz accepted this revision.Apr 12 2025, 10:00 PM

emaste accepted this revision.Apr 12 2025, 10:14 PM

This revision is now accepted and ready to land.Apr 12 2025, 10:14 PM

Closed by commit rG78e25e65bf38: lindebugfs: Add `debugfs_create_str()`. · Explain WhyApr 13 2025, 10:01 AM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rG78e25e65bf38: lindebugfs: Add `debugfs_create_str()`.

Revision Contents
Changeset List

Path

Size

sys/

compat/

lindebugfs/

115 line(s)

linuxkpi/

common/

include/

linux/

2 line(s)

modules/

lindebugfs/

1 line

Diff 153602

sys/compat/lindebugfs/lindebugfs.c

Loading...

sys/compat/linuxkpi/common/include/linux/debugfs.h

Loading...

sys/modules/lindebugfs/Makefile

Loading...