sptr can never be NULL at this point, based on the context. The
intent was clearly to check if *sptr is now 0 so that we zap the state
and freshly process the next lookup.
Sponsored by: Klara, Inc.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 63327 Build 60211: arc lint + arc unit
Event Timeline
| lib/libc/locale/collate.c | ||
|---|---|---|
| 340 | Actually, it's not clear to me that the left half is correct, either. | |
| lib/libc/locale/collate.c | ||
|---|---|---|
| 340 | Right, that can never be true since it would otherwise imply that sptr == sptr + 1. | |
| lib/libc/locale/collate.c | ||
|---|---|---|
| 340 | Yeah. I was wondering if it could be some kind of typo, but I can't imagine what the "correct" version would look like- I think I'll just remove it, as I can't see why we'd terminate any earlier than pri == 0. | |