Page MenuHomeFreeBSD
Differential D5215

Use taskqueue_fast to process messages
ClosedPublic
Actions

Authored by howard0su_gmail.com on Feb 6 2016, 3:14 AM.
Tags
None
Referenced Files
F81970495: D5215.diff
Sat, Dec 14, 5:48 PM
Unknown Object (File)
Sun, Nov 24, 12:48 AM
Unknown Object (File)
Sat, Nov 23, 12:22 AM
Unknown Object (File)
Tue, Nov 19, 1:16 PM
Unknown Object (File)
Mon, Nov 18, 11:14 AM
Unknown Object (File)
Mon, Nov 18, 3:06 AM
Unknown Object (File)
Mar 17 2024, 12:30 AM
Unknown Object (File)
Feb 9 2024, 12:53 AM
View All Files
Subscribers
cem
imp
Contributor Reviews (src)

Details

Reviewers
honzhan_microsoft.com
decui_microsoft.com
cem
sepherosa_gmail.com
Commits
rS297178: hyperv/vmbus: Remove NULL check for taskqueue_create_fast(M_WAITOK)
rS297177: hyperv/vmbus: Use taskqueue_fast for non-performance critical messages

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2961
Build 2989: arc lint + arc unit

Event Timeline

howard0su_gmail.com updated this revision to Diff 13085.Feb 6 2016, 3:14 AM
howard0su_gmail.com retitled this revision from to Use taskqueue_fast to process messages.
howard0su_gmail.com updated this object.
howard0su_gmail.com edited the test plan for this revision. (Show Details)
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptFeb 6 2016, 3:14 AM
howard0su_gmail.com added reviewers: sepherosa_gmail.com, honzhan_microsoft.com, decui_microsoft.com.Mar 12 2016, 2:22 PM
cem requested changes to this revision.Mar 12 2016, 4:38 PM
cem added a reviewer: cem.
cem added a subscriber: cem.
cem added inline comments.
sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
205

taskqueue_enqueue_fast() was removed in r296272, which you submitted?

This revision now requires changes to proceed.Mar 12 2016, 4:38 PM
howard0su_gmail.com updated this revision to Diff 14292.Mar 13 2016, 1:19 PM
howard0su_gmail.com edited edge metadata.

Rebase to master and use taskqueue_enqueue for fast queue

decui_microsoft.com accepted this revision.Mar 13 2016, 1:36 PM
decui_microsoft.com edited edge metadata.

LGTM

howard0su_gmail.com updated this revision to Diff 14467.Mar 21 2016, 6:28 AM
howard0su_gmail.com edited edge metadata.

Use SINT4 for eventtimer instead of SINT2 that shares with others.

sepherosa_gmail.com accepted this revision.Mar 21 2016, 6:47 AM
sepherosa_gmail.com edited edge metadata.

We will split this into two patches. One changes the eventtimer's position (SINT change). One will prefer the taskq over the swi.

howard0su_gmail.com updated this revision to Diff 14474.Mar 21 2016, 1:03 PM
howard0su_gmail.com edited edge metadata.

split patch

howard0su_gmail.com added a parent revision: D5696: Use SINT4 instead of SINT2 for eventtimer messages..Mar 21 2016, 1:04 PM
sepherosa_gmail.com accepted this revision.Mar 21 2016, 2:14 PM
sepherosa_gmail.com edited edge metadata.
Closed by commit rS297177: hyperv/vmbus: Use taskqueue_fast for non-performance critical messages (authored by sephe). · Explain WhyMar 22 2016, 6:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
vmbus/
2 lines
16 lines
60 lines
6 lines

Diff 14467

View Options

sys/dev/hyperv/vmbus/hv_et.c

Loading...
View Options

sys/dev/hyperv/vmbus/hv_hv.c

Loading...
View Options

sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c

Loading...
View Options

sys/dev/hyperv/vmbus/hv_vmbus_priv.h

Loading...