Differential D5439

hyperv: Use atomic_fetchadd_int to get GPADL id.
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Feb 25 2016, 8:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mar 23 2024, 1:47 AM

	Unknown Object (File)
	Feb 16 2024, 7:13 AM

	Unknown Object (File)
	Feb 16 2024, 6:08 AM

	Unknown Object (File)
	Dec 20 2023, 1:38 AM

	Unknown Object (File)
	Apr 23 2017, 8:26 AM

	Unknown Object (File)
	Apr 20 2017, 3:33 PM

	Unknown Object (File)
	Jan 1 2017, 10:05 AM

	Unknown Object (File)
	Dec 26 2016, 9:04 PM

View All 30 Files

Subscribers

None

Details

Reviewers

howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger
adrian

Commits

rS296076: hyperv: Use atomic_fetchadd_int to get GPADL id.

Summary

Read then atomic_add_int is not MPSAFE.

And don't decrease the global GPADL id upon GPADL establish messages allocation failure, which should be really rare (and we should convert the message allocation to use M_WAITOK); add comment about why we _must_ not decrease the global GPADL id there.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 13722.Feb 25 2016, 8:38 AM

sepherosa_gmail.com retitled this revision from to hyperv: Use atomic_fetchadd_int to get GPADL id..

sepherosa_gmail.com updated this object.

sepherosa_gmail.com edited the test plan for this revision. (Show Details)

sepherosa_gmail.com added reviewers: adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.

Yes, substract the next_gpadl_handle is risk here.

honzhan_microsoft.com accepted this revision.Feb 25 2016, 9:04 AM

honzhan_microsoft.com edited edge metadata.

This revision is now accepted and ready to land.Feb 25 2016, 9:04 AM

Closed by commit rS296076: hyperv: Use atomic_fetchadd_int to get GPADL id. (authored by sephe). · Explain WhyFeb 26 2016, 11:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

hyperv/

vmbus/

19 lines

Diff 13778

head/sys/dev/hyperv/vmbus/hv_channel.c

Loading...