Differential D5904

Remove NULL check before free(9)
AbandonedPublic
Actions

Authored by howard0su_gmail.com on Apr 11 2016, 5:28 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Feb 22 2024, 8:08 PM

	Unknown Object (File)
	Feb 9 2024, 5:02 PM

	Unknown Object (File)
	Jan 18 2024, 12:29 AM

	Unknown Object (File)
	Dec 22 2023, 11:29 PM

	Unknown Object (File)
	Dec 8 2023, 7:09 AM

	Unknown Object (File)
	Dec 8 2023, 7:06 AM

	Unknown Object (File)
	Nov 22 2023, 8:49 PM

	Unknown Object (File)
	Nov 22 2023, 8:19 AM

View All 60 Files

Subscribers

Contributor Reviews (src)

Details

Reviewers

cem
jmg
gnn
sbruno

Group Reviewers

Intel Networking

Summary

Use the following script of Conccinelle:
@@
expression E;
expression X;
@@

-if (E != NULL) {

free(E, X);
...

-}

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

howard0su_gmail.com updated this revision to Diff 15059.Apr 11 2016, 5:28 AM

howard0su_gmail.com retitled this revision from to Remove NULL check before free(9).

howard0su_gmail.com updated this object.

howard0su_gmail.com edited the test plan for this revision. (Show Details)

howard0su_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added reviewers: gnn, jmg, sbruno, Intel Networking. · View Herald TranscriptApr 11 2016, 5:28 AM

Herald added subscribers: Contributor Reviews (src), asomers, gnn and 2 others. · View Herald Transcript

allanjude added a subscriber: allanjude.Apr 11 2016, 5:55 AM

allanjude added inline comments.

sys/dev/acpica/acpi_thermal.c
961	Indent appears wrong here.
sys/dev/atkbdc/atkbd.c
459	the script seems to have missed some of the other calls to free() here
sys/dev/ciss/ciss.c
1287	indent
1782	indent
sys/dev/drm2/i915/dvo_ch7017.c
404	Not sure we want to mess with the i915 files where we are trying to stay in sync with Linux

I don't think this transformation is correct. It's not valid to lift everything out of the if(){}, only the free() itself. And if there are other statements in the if(){}, I don't believe this improves clarity.

Like Allan pointed out, drm2/i915 is mostly contrib code from Linux; I'd prefer to leave that alone to ease porting efforts.

sys/dev/drm2/i915/dvo_ch7017.c
404	Agreed, and this transformation seems wrong anyway. Only the free can be lifted out of the if(){}.

This revision now requires changes to proceed.Apr 11 2016, 6:01 AM

The patch is still refining. I submit this to see if there is strong objection not to do this. (remove null check)

sys/dev/drm2/i915/dvo_ch7017.c
404	I will skip drm code and code under contrib. For this case, I still believe the logic is correct. dvo->dev_priv was pointing to priv. priv = malloc(sizeof(struct ch7017_priv), DRM_MEM_KMS, M_NOWAIT \| M_ZERO); if (priv == NULL) return false; dvo->i2c_bus = adapter; -------dvo->dev_priv = priv;

howard0su_gmail.com updated this revision to Diff 15066.Apr 11 2016, 7:49 AM

howard0su_gmail.com edited edge metadata.

Herald edited edge metadata. · View Herald TranscriptApr 11 2016, 7:49 AM

Some of these files, for example firewire and reiserfs, are not built by default. Make sure you compile test them with a suitable kernel config file.

asomers added inline comments.Apr 11 2016, 4:23 PM

sys/crypto/via/padlock_hash.c
188	Whitespace bug
sys/dev/iscsi_initiator/isc_subr.c
258	Whitespace bug
sys/dev/iscsi_initiator/iscsi_subr.c
330	Whitespace bug
337	Whitespace bug here too
sys/dev/pms/freebsd/driver/common/lxutil.c
693	This looks suspect. Will pCardInfo->tiCacheMem[idx] commonly already be NULL? If so, then your change will DOS the system console. Without knowing how lxutil works or hearing from lxutil's maintainer, I don't think you should change it.
sys/kern/kern_jail.c
2759	Did you mean to add the newline here and on line 3098?
sys/netpfil/ipfw/ip_dummynet.c
1249	whitespace bug

I have to split this into small changeset and manually cleanup more stlye(9)

Revision Contents
Changeset List

Path

Size

sys/

arm/

samsung/

exynos/

4 lines

boot/

kshim/

4 lines

cam/

ata/

24 lines

scsi/

32 lines

compat/

svr4/

6 lines

crypto/

via/

11 lines

dev/

acpica/

6 lines

6 lines

an/

12 lines

ath/

if_ath_lna_div.c

6 lines

if_ath_spectral.c

4 lines

atkbdc/

6 lines

bktr/

6 lines

bxe/

12 lines

ciss/

18 lines

cxgb/

4 lines

cy/

6 lines

digi/

18 lines

drm/

14 lines

drm2/

8 lines

i915/

6 lines

6 lines

6 lines

6 lines

6 lines

6 lines

radeon/

radeon_connectors.c

18 lines

e1000/

6 lines

12 lines

12 lines

fb/

42 lines

firewire/

6 lines

gpio/

12 lines

hwpmc/

13 lines

hyperv/

netvsc/

12 lines

storvsc/

hv_storvsc_drv_freebsd.c

10 lines

vmbus/

hv_connection.c

6 lines

iscsi_initiator/

18 lines

12 lines

isp/

24 lines

ixgb/

12 lines

ixgbe/

12 lines

ixl/

12 lines

kbdmux/

6 lines

malo/

12 lines

mca/

4 lines

mfi/

14 lines

mpt/

6 lines

24 lines

mwl/

12 lines

netmap/

6 lines

otus/

12 lines

pci/

6 lines

pms/

freebsd/

driver/

common/

8 lines

ini/

src/

5 lines

ppbus/

12 lines

rp/

6 lines

sio/

6 lines

sound/

pci/

6 lines

6 lines

6 lines

pcm/

18 lines

usb/

6 lines

urtwn/

6 lines

usb/

input/

4 lines

serial/

8 lines

4 lines

7 lines

6 lines

wlan/

6 lines

virtio/

balloon/

virtio_balloon.c

6 lines

network/

13 lines

vkbd/

6 lines

vmware/

vmxnet3/

12 lines

xen/

blkback/

44 lines

blkfront/

6 lines

grant_table/

4 lines

netback/

6 lines

netback_unit_tests.c

8 lines

fs/

cd9660/

cd9660_vfsops.c

6 lines

devfs/

6 lines

nandfs/

nandfs_vfsops.c

6 lines

nfsclient/

6 lines

unionfs/

6 lines

geom/

eli/

6 lines

raid/

72 lines

12 lines

18 lines

18 lines

6 lines

18 lines

6 lines

6 lines

6 lines

gnu/

fs/

reiserfs/

reiserfs_vfsops.c

14 lines

i386/

ibcs2/

12 lines

kern/

12 lines

6 lines

6 lines

12 lines

6 lines

6 lines

kgssapi/

gss_release_buffer.c

4 lines

krb5/

8 lines

net/

altq/

8 lines

13 lines

netgraph/

6 lines

6 lines

netinet/

12 lines

netipsec/

24 lines

netpfil/

ipfw/

18 lines

6 lines

netsmb/

10 lines

6 lines

nfs/

6 lines

pc98/

cbus/

6 lines

rpc/

18 lines

tests/

callout_test/

12 lines

ufs/

ffs/

6 lines

12 lines

xdr/

6 lines

xen/

xenbus/

19 lines

6 lines

xenbusb_front.c

6 lines

Diff 15066

sys/arm/samsung/exynos/chrome_kb.c

Loading...

sys/boot/kshim/bsd_kernel.c

Loading...

sys/cam/ata/ata_xpt.c

Loading...

sys/cam/scsi/scsi_xpt.c

Loading...

sys/compat/svr4/svr4_misc.c

Loading...

sys/crypto/via/padlock_hash.c

Loading...

sys/dev/acpica/acpi_perf.c

Loading...

sys/dev/acpica/acpi_thermal.c

Loading...

sys/dev/an/if_an.c

Loading...

sys/dev/ath/if_ath_lna_div.c

Loading...

sys/dev/ath/if_ath_spectral.c

Loading...

sys/dev/atkbdc/atkbd.c

Loading...

sys/dev/bktr/msp34xx.c

Loading...

sys/dev/bxe/bxe.c

Loading...

sys/dev/ciss/ciss.c

Loading...

sys/dev/cxgb/cxgb_sge.c

Loading...

sys/dev/cy/cy.c

Loading...

sys/dev/digi/digi.c

Loading...

sys/dev/drm/drm_drv.c

Loading...

sys/dev/drm2/drm_stub.c

Loading...

sys/dev/drm2/i915/dvo_ch7017.c

Loading...

sys/dev/drm2/i915/dvo_ch7xxx.c

Loading...

sys/dev/drm2/i915/dvo_ivch.c

Loading...

sys/dev/drm2/i915/dvo_ns2501.c

Loading...

sys/dev/drm2/i915/dvo_sil164.c

Loading...

sys/dev/drm2/i915/dvo_tfp410.c

Loading...

sys/dev/drm2/radeon/radeon_connectors.c

Loading...

sys/dev/e1000/if_em.c

Loading...

sys/dev/e1000/if_igb.c

Loading...

sys/dev/e1000/if_lem.c

Loading...

sys/dev/fb/vesa.c

Loading...

sys/dev/firewire/sbp_targ.c

Loading...

sys/dev/gpio/gpiobus.c

Loading...

sys/dev/hwpmc/hwpmc_mod.c

Loading...

sys/dev/hyperv/netvsc/hv_net_vsc.c

Loading...

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c

Loading...

sys/dev/hyperv/vmbus/hv_connection.c

Loading...

sys/dev/iscsi_initiator/isc_subr.c

Loading...

sys/dev/iscsi_initiator/iscsi_subr.c

Loading...

sys/dev/isp/isp_pci.c

Loading...

sys/dev/ixgb/if_ixgb.c

Loading...

sys/dev/ixgbe/ix_txrx.c

Loading...

sys/dev/ixl/ixl_txrx.c

Loading...

sys/dev/kbdmux/kbdmux.c

Loading...

sys/dev/malo/if_malo.c

Loading...

sys/dev/mca/mca_bus.c

Loading...

sys/dev/mfi/mfi.c

Loading...

sys/dev/mpt/mpt_cam.c

Loading...

sys/dev/mpt/mpt_raid.c

Loading...

sys/dev/mwl/if_mwl.c

Loading...

sys/dev/netmap/netmap_vale.c

Loading...

sys/dev/otus/if_otus.c

Loading...

sys/dev/pci/pci.c

Loading...

sys/dev/pms/freebsd/driver/common/lxutil.c

Loading...

sys/dev/pms/freebsd/driver/ini/src/agtiapi.c

Loading...

sys/dev/ppbus/if_plip.c

Loading...

sys/dev/rp/rp_pci.c

Loading...

sys/dev/sio/sio.c

Loading...

sys/dev/sound/pci/envy24.c

Loading...

sys/dev/sound/pci/envy24ht.c

Loading...

sys/dev/sound/pci/hdspe-pcm.c

Loading...

sys/dev/sound/pcm/feeder_rate.c

Loading...

sys/dev/sound/usb/uaudio.c

Loading...

sys/dev/urtwn/if_urtwn.c

Loading...

sys/dev/usb/input/ums.c

Loading...

sys/dev/usb/serial/ucycom.c

Loading...

sys/dev/usb/serial/ufoma.c

Loading...

sys/dev/usb/usb_dev.c

Loading...

sys/dev/usb/usb_device.c

Loading...

sys/dev/usb/wlan/if_rsu.c

Loading...

sys/dev/virtio/balloon/virtio_balloon.c

Loading...

sys/dev/virtio/network/if_vtnet.c

Loading...

sys/dev/vkbd/vkbd.c

Loading...

sys/dev/vmware/vmxnet3/if_vmx.c

Loading...

sys/dev/xen/blkback/blkback.c

Loading...

sys/dev/xen/blkfront/blkfront.c

Loading...

sys/dev/xen/grant_table/grant_table.c

Loading...

sys/dev/xen/netback/netback.c

Loading...

sys/dev/xen/netback/netback_unit_tests.c

Loading...

sys/fs/cd9660/cd9660_vfsops.c

Loading...

sys/fs/devfs/devfs_devs.c

Loading...

sys/fs/nandfs/nandfs_vfsops.c

Loading...

sys/fs/nfsclient/nfs_clstate.c

Loading...

sys/fs/unionfs/union_subr.c

Loading...

sys/geom/eli/g_eli.c

Loading...

sys/geom/raid/md_ddf.c

Loading...

sys/geom/raid/md_intel.c

Loading...

sys/geom/raid/md_jmicron.c

Loading...

sys/geom/raid/md_nvidia.c

Loading...

sys/geom/raid/md_promise.c

Loading...

sys/geom/raid/md_sii.c

Loading...

sys/geom/raid/tr_raid1.c

Loading...

sys/geom/raid/tr_raid1e.c

Loading...

sys/geom/raid/tr_raid5.c

Loading...

sys/gnu/fs/reiserfs/reiserfs_vfsops.c

Loading...

sys/i386/ibcs2/ibcs2_misc.c

Loading...

sys/kern/kern_dtrace.c

Loading...

sys/kern/kern_exec.c

Loading...

sys/kern/kern_jail.c

Loading...

sys/kern/kern_linker.c

Loading...

sys/kern/kern_proc.c

Loading...

sys/kern/vfs_export.c

Loading...

sys/kgssapi/gss_release_buffer.c

Loading...

sys/kgssapi/krb5/krb5_mech.c

Loading...

sys/net/altq/altq_hfsc.c

Loading...

sys/net/if_vxlan.c

Loading...

sys/netgraph/ng_mppc.c

Loading...

sys/netgraph/ng_pipe.c

Loading...

sys/netinet/ip_id.c

Loading...

sys/netipsec/key.c

Loading...

sys/netpfil/ipfw/ip_dummynet.c

Loading...

sys/netpfil/ipfw/ip_fw_table.c

Loading...

sys/netsmb/smb_crypt.c

Loading...

sys/netsmb/smb_trantcp.c

Loading...

sys/nfs/krpc_subr.c

Loading...

sys/pc98/cbus/sio.c

Loading...

sys/rpc/svc.c

Loading...

sys/tests/callout_test/callout_test.c

Loading...

sys/ufs/ffs/ffs_softdep.c

Loading...

sys/ufs/ffs/ffs_vfsops.c

Loading...

sys/xdr/xdr_sizeof.c

Loading...

sys/xen/xenbus/xenbusb.c

Loading...

sys/xen/xenbus/xenbusb_back.c

Loading...

sys/xen/xenbus/xenbusb_front.c

Loading...