Page MenuHomeFreeBSD
Differential D5909

hyperv/hv: use MSR to hint hypervisor on entering idle.
AbandonedPublic
Actions

Authored by howard0su_gmail.com on Apr 11 2016, 12:19 PM.
Tags
None
Referenced Files
F81970370: D5909.diff
Sat, Dec 14, 5:35 PM
Unknown Object (File)
Apr 8 2024, 8:52 PM
Unknown Object (File)
Apr 8 2024, 5:10 PM
Unknown Object (File)
Mar 18 2024, 4:16 AM
Unknown Object (File)
Feb 22 2024, 7:19 PM
Unknown Object (File)
Feb 8 2024, 10:04 PM
Unknown Object (File)
Dec 20 2023, 1:48 AM
Unknown Object (File)
Dec 7 2023, 6:29 PM
View All 49 Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
honzhan_microsoft.com
decui_microsoft.com
sepherosa_gmail.com

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3212
Build 3245: arc lint + arc unit

Event Timeline

howard0su_gmail.com updated this revision to Diff 15076.Apr 11 2016, 12:19 PM
howard0su_gmail.com retitled this revision from to hyperv/hv: use MSR to hint hypervisor on entering idle..
howard0su_gmail.com updated this object.
howard0su_gmail.com edited the test plan for this revision. (Show Details)
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptApr 11 2016, 12:19 PM
howard0su_gmail.com updated this revision to Diff 15077.Apr 11 2016, 12:30 PM

mismerge one line, add it back

howard0su_gmail.com added reviewers: decui_microsoft.com, honzhan_microsoft.com, sepherosa_gmail.com.Apr 15 2016, 8:06 AM
sepherosa_gmail.com added inline comments.Apr 15 2016, 8:24 AM
sys/dev/hyperv/vmbus/hv_hv.c
521

Hmm, we should make the test more stringent:

if ((hyperv_features & HV_FEATURE_MSR_GUEST_IDLE) &&
    (hyperv_features3 & HV_FEATURE3_GUEST_IDLE))
522

Well, does it really work for you? acpi_cpu will override cpu_idle_hook unconditionally later.

howard0su_gmail.com added inline comments.Apr 15 2016, 10:35 AM
sys/dev/hyperv/vmbus/hv_hv.c
522

I set the breakpoint in DDB to make sure it works. I believe acpi_cpu is earlier.

sepherosa_gmail.com added inline comments.Apr 18 2016, 2:02 AM
sys/dev/hyperv/vmbus/hv_hv.c
522

I added a log in hyperv_init() and acpi_cpu_startup(), see the last line in the two log chunks.

...
Apr 18 09:57:02 perf01-sephe kernel: FreeBSD clang version 3.8.0 (tags/RELEASE_380/final 262564) (based on LLVM 3.8.0)
Apr 18 09:57:02 perf01-sephe kernel: Hyper-V Version: 6.3.9600 [SP18]
Apr 18 09:57:02 perf01-sephe kernel: Features=0xe7f<VPRUNTIME,TMREFCNT,SYNIC,SYNTM,APIC,HYPERCALL,VPINDEX,REFTSC,IDLE,TMFREQ>
Apr 18 09:57:02 perf01-sephe kernel: PM Features=max C2, 0x0
Apr 18 09:57:02 perf01-sephe kernel: Features3=0x17b2<DEBUG,XMMHC,IDLE,NUMA,TMFREQ,SYNCMC,CRASH,NPIEP>
Apr 18 09:57:02 perf01-sephe kernel: Timecounter "Hyper-V" frequency 10000000 Hz quality 10000000
Apr 18 09:57:02 perf01-sephe kernel: hyperv init
...
...
...
Apr 18 09:57:02 perf01-sephe kernel: sc0: VGA <16 virtual consoles, flags=0x300>
Apr 18 09:57:02 perf01-sephe kernel: vga0: <Generic ISA VGA> at port 0x3c0-0x3df iomem 0xa0000-0xbffff on isa0
Apr 18 09:57:02 perf01-sephe kernel: Timecounters tick every 1.000 msec
Apr 18 09:57:02 perf01-sephe kernel: acpi_cpu override idle hook
...

I think you were adding the ddb brkptr to the MSR idle routing; the MSR version would be triggered before the ACPI cpu overrides, but it does not mean ACPI cpu takes over the idle hook earlier.

howard0su_gmail.com abandoned this revision.Apr 19 2016, 2:54 PM

This need more testing and some change in my private tree is dependency for this change.

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
vmbus/
13 lines
1 line

Diff 15077

View Options

sys/dev/hyperv/vmbus/hv_hv.c

Loading...
View Options

sys/dev/hyperv/vmbus/hv_vmbus_priv.h

Loading...