Page MenuHomeFreeBSD
Differential D6955

hyperv/stor: Fix the issue of uncorrect disk filtering
ClosedPublic
Actions

Authored by honzhan_microsoft.com on Jun 24 2016, 6:54 AM.
Tags
None
Referenced Files
F81970492: D6955.diff
Sat, Dec 14, 5:47 PM
Unknown Object (File)
Sun, Nov 17, 4:30 AM
Unknown Object (File)
Sun, Nov 17, 2:22 AM
Unknown Object (File)
Mar 23 2024, 1:27 AM
Unknown Object (File)
Mar 3 2024, 2:42 PM
Unknown Object (File)
Feb 16 2024, 7:06 AM
Unknown Object (File)
Feb 16 2024, 6:01 AM
Unknown Object (File)
Jan 29 2024, 10:32 PM
View All 56 Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
howard0su_gmail.com
decui_microsoft.com
sepherosa_gmail.com
royger
mav
Commits
rS302541: hyperv/stor: Fix the INQUIRY checks
Summary

This fixes the smartctl issue and hot plugin disk issue.

The INQUIRY response sometimes are quite short (less than 36),
then it cannot be used to verify. So, only the response is greater
or equal to 36, the validation can be applied.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209443
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210425

Submitted by: Hongjiang Zhang <honzhan microsoft com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4331
Build 4376: arc lint + arc unit

Event Timeline

honzhan_microsoft.com updated this revision to Diff 17848.Jun 24 2016, 6:54 AM
honzhan_microsoft.com retitled this revision from to hyperv/stor: Fix the issue of uncorrect disk filtering.
honzhan_microsoft.com updated this object.
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJun 24 2016, 6:54 AM
honzhan_microsoft.com added reviewers: sepherosa_gmail.com, royger, decui_microsoft.com, howard0su_gmail.com.Jun 24 2016, 7:16 AM
honzhan_microsoft.com updated this revision to Diff 17853.Jun 24 2016, 10:34 AM
honzhan_microsoft.com removed rS FreeBSD src repository - subversion as the repository for this revision.
honzhan_microsoft.com added a reviewer: mva.
honzhan_microsoft.com updated this revision to Diff 17910.Jun 27 2016, 2:04 AM
decui_microsoft.com accepted this revision.Jun 27 2016, 7:17 AM
decui_microsoft.com edited edge metadata.
This revision is now accepted and ready to land.Jun 27 2016, 7:17 AM
sepherosa_gmail.com accepted this revision.Jun 27 2016, 8:15 AM
sepherosa_gmail.com edited reviewers, added: mav; removed: mva.
sepherosa_gmail.com edited edge metadata.
Closed by commit rS302541: hyperv/stor: Fix the INQUIRY checks (authored by sephe). · Explain WhyJul 11 2016, 5:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
storvsc/
55 lines

Diff 17848

View Options

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c

Loading...