Details

Reviewers

tuexen
jtl
thj
rrs
glebius

Group Reviewers

transport

Summary

This Diff builds upon D21011. A simplistic reflector for
the received CE, ECT1 and ECT0 marked data bytes in the
AccECN TCP option - which is sent on every ACK, in full.
Only when space is needed for SACK, an abbreviated option
is constructed and sent (if possible).

Potential enhancements: Track which counters changed, and
send only changed counters repeatedly (e.g. 3 times at least)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 48203
Build 45090: arc lint + arc unit

Event Timeline

rscheff created this revision.Aug 23 2022, 9:10 AM

Herald added a reviewer: transport. · View Herald TranscriptAug 23 2022, 9:10 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Aug 23 2022, 9:10 AM

Harbormaster completed remote builds in B47066: Diff 109702.Aug 23 2022, 9:10 AM

rebase to main

Harbormaster completed remote builds in B47201: Diff 110016.Aug 31 2022, 1:52 PM

validating this diff against accecn packetdrill scripts from Linux (Ilpo). Once done, will bring this up again.

move ecn sysctls to tcp_ecn.c
go with AccECN options from a compile time option to a global setting
document the new sysctl option
remove outdated comment

Harbormaster completed remote builds in B47660: Diff 111278.Sep 30 2022, 3:44 PM

rebase to main

Harbormaster completed remote builds in B47772: Diff 111633.Oct 11 2022, 8:45 AM

ensure control packets have accecn opt, if enabled

Harbormaster completed remote builds in B47838: Diff 111807.Oct 14 2022, 1:39 PM

gbe added a subscriber: gbe.Oct 26 2022, 8:46 PM

move ecn sysctls to tcp_ecn.c
go with AccECN options from a compile time option to a global setting
document the new sysctl option
remove outdated comment
add logging, and make syncache response honor most recent incoming SYN fields
add logging
more logging
ensure control packets have accecn opt, if enabled
fix packt_this_ack bug
bump man date
received accecn counter into tcpinfo
add more tcpinfo counters
make accecn option counters a struct within tcpcb, which can also be locally allocated (syncache, prior of tcpcb)
initialize to_ae properly
reference properly to counters
bump man page date
remove all logging

Harbormaster completed remote builds in B48203: Diff 112714.Nov 7 2022, 10:18 AM

add ntoh24 and hton24 to improve readability
compact AccECN opt decoding
straighten option output path

Harbormaster completed remote builds in B52102: Diff 123335.Jun 16 2023, 12:34 PM

use temp variable to improve readability

Harbormaster completed remote builds in B52108: Diff 123352.Jun 16 2023, 6:04 PM

rebase to main

Harbormaster completed remote builds in B55461: Diff 132863.Jan 17 2024, 8:09 AM

rebase main

Harbormaster completed remote builds in B56082: Diff 134552.Feb 18 2024, 10:27 AM

Commit	Tree	Parents	Author	Summary	Date
6302fdd541e7	d6d46f3c5fb9	c9f6458c809b	Richard Scheffenegger	remove all logging	Nov 7 2022, 10:17 AM
c9f6458c809b	e20e26954a90	c98b9b75bf89	Richard Scheffenegger	bump man page date	Nov 7 2022, 10:03 AM
c98b9b75bf89	14a3a507080c	6697e63bd522	Richard Scheffenegger	reference properly to counters	Nov 7 2022, 9:35 AM
6697e63bd522	6323d215ac70	a9366d2add8a	Richard Scheffenegger	initialize to_ae properly	Nov 6 2022, 4:51 PM
a9366d2add8a	c614f3123b7d	44b15a689686	Richard Scheffenegger	make accecn option counters a struct within tcpcb, which can also be locally… (Show More…)	Nov 6 2022, 3:51 PM
44b15a689686	2b2adb6c4803	d9a8c2892ef3	Richard Scheffenegger	add more tcpinfo counters	Nov 6 2022, 2:20 PM
d9a8c2892ef3	d69bc0bb6075	c6991088b111	Richard Scheffenegger	received accecn counter into tcpinfo	Nov 6 2022, 11:53 AM
c6991088b111	8acb589f5375	05188830bb7d	Richard Scheffenegger	bump man date	Nov 6 2022, 11:27 AM
05188830bb7d	105b945e7925	11cc0b6eb561	Richard Scheffenegger	fix packt_this_ack bug	Nov 5 2022, 4:25 PM
11cc0b6eb561	dcb6eb4e0541	aa2dbdfbc090	Richard Scheffenegger	ensure control packets have accecn opt, if enabled	Oct 14 2022, 1:38 PM
aa2dbdfbc090	deb6a1eb7c5f	c14e66f29e5b	Richard Scheffenegger	more logging	Oct 12 2022, 5:32 PM
c14e66f29e5b	1b5e5e9424ac	84eeddf98bce	Richard Scheffenegger	add logging	Oct 12 2022, 4:08 PM
84eeddf98bce	630765c90d26	0d5497a2cb63	Richard Scheffenegger	add logging, and make syncache response honor most recent incoming SYN fields	Oct 4 2022, 2:18 PM
0d5497a2cb63	d7909492a4b9	4e6019ed6337	Richard Scheffenegger	remove outdated comment	Sep 30 2022, 3:43 PM
4e6019ed6337	dbd33fc84d27	ffaaff5239eb	Richard Scheffenegger	document the new sysctl option	Sep 30 2022, 3:41 PM
ffaaff5239eb	4d4b704da991	d7482e9bb7b0	Richard Scheffenegger	go with AccECN options from a compile time option to a global setting	Sep 30 2022, 3:36 PM
d7482e9bb7b0	d938cc8c26d7	a80c1ba83b3b	Richard Scheffenegger	move ecn sysctls to tcp_ecn.c	Sep 30 2022, 12:42 PM
a80c1ba83b3b	59516c1a8b57	64fc93594bcd	Richard Scheffenegger	Implement AccECN option (w/ early assigned option number) (Show More…)	Aug 23 2022, 8:58 AM
64fc93594bcd	6ac3ec034525	848e4a016983	Richard Scheffenegger	add accecn-opt to syncache, and initialize values; NOTE: fixup for DATA in SYN.. (Show More…)	Aug 22 2022, 1:21 PM
848e4a016983	b1d4ca4b8816	ee943416356b	Richard Scheffenegger	use early assigned TCP options codepoints	Aug 7 2022, 6:41 AM
ee943416356b	49716f00c119	f2b315536769	Richard Scheffenegger	make experimental AccECN option align with Linux	Jul 25 2022, 12:52 AM
f2b315536769	21d5ac43c206	438b5871d31e	Richard Scheffenegger	use 0xac and 0xae for AccECN option	Jul 24 2022, 3:29 PM
438b5871d31e	6221d1952add	4caea74a201f	Richard Scheffenegger	initialize local accecn byte counters	Feb 12 2022, 11:17 PM
4caea74a201f	c9e703284785	b8ca119080d9	Richard Scheffenegger	fix TCP_ACCECNOPT compile option fix experimental tcpopt	Feb 11 2022, 3:52 PM
b8ca119080d9	68006f3cb778	874bc6a45a21	Richard Scheffenegger	make AccECN TCP options a compile time option	Feb 11 2022, 12:37 PM
874bc6a45a21	069ffb054bba	a2d21dee41bd	Richard Scheffenegger	bracket AccECN option with compile #ifdef TCP_ACCECNOPT	Feb 11 2022, 12:11 PM
a2d21dee41bd	8be5257900a0	86860acade02	Richard Scheffenegger	first attempt at providing AccECN option	Feb 7 2022, 2:32 AM
86860acade02	b76f45e9a0ca	520148556f4e	Richard Scheffenegger	manual rebase to main	Jan 31 2022, 12:22 PM
520148556f4e	018d0422d4ed	dda70efaf1e9	Richard Scheffenegger	remove logging again	Feb 6 2022, 2:14 PM
dda70efaf1e9	dcda0c610fcc	095cc325ffef	Richard Scheffenegger	add logging to troubleshoot iptos oddity	Feb 2 2022, 10:07 PM
095cc325ffef	b76f45e9a0ca	2eec70c5f3a9	Richard Scheffenegger	manual rebase to main	Jan 31 2022, 12:22 PM
2eec70c5f3a9	666e99dfc1e2	3ceff0bcc1b5	Richard Scheffenegger	removing logging	Jul 24 2022, 2:40 AM
3ceff0bcc1b5	8d5e7a80bfe3	e6def2d9f005	Richard Scheffenegger	fixed 2 oversights, added logging	Jul 24 2022, 2:37 AM
e6def2d9f005	666e99dfc1e2	6fe96011b91f	Richard Scheffenegger	thflags is fully propulated for KASSERT fix syn-sent ecn negotiation	Feb 10 2022, 3:15 AM
6fe96011b91f	627445ba8afb	e1c227fbc0b8	Richard Scheffenegger	cleaning up a set of KMOD_ macros, and nicifying source code	Feb 6 2022, 9:20 PM
e1c227fbc0b8	018d0422d4ed	176ce50b216b	Richard Scheffenegger	remove logging again	Feb 6 2022, 2:14 PM
176ce50b216b	bf19e76536b0	2a30abc6517d	Richard Scheffenegger	add logging to troubleshoot iptos oddity	Feb 2 2022, 10:07 PM
2a30abc6517d	799a9bde0894	61928eaf59ef	Richard Scheffenegger	use uint16_t consistently for thflags, rather than passing pointers	Feb 2 2022, 9:13 PM
61928eaf59ef	b8a1c1f8c4df	ce5e99c6fbfb	Richard Scheffenegger	troubleshoot rack (ect0 on control packet)	Feb 2 2022, 6:48 PM
ce5e99c6fbfb	a7b73ce1b2e5	5a34803d5490	Richard Scheffenegger	fix up rack fast_output	Feb 2 2022, 4:30 PM
5a34803d5490	cf5b36a9ea2c	f5e857c000e4	Richard Scheffenegger	fixing cwr to go only with new data, update rack	Feb 2 2022, 4:13 PM
f5e857c000e4	5a31564fe909	87ddca4c0554	Richard Scheffenegger	do proper output handling also for parallel SYN	Feb 2 2022, 2:14 PM
87ddca4c0554	8588c58089e5	8937656da389	Richard Scheffenegger	proper logging when handling ecn	Feb 2 2022, 12:03 PM
8937656da389	a1022b85c40d	8093786eeebe	Richard Scheffenegger	adding logging output, handle parallel SYN for ECN	Feb 2 2022, 10:05 AM
8093786eeebe	45d19d55c6ee	82112764b2c2	Richard Scheffenegger	prepare rack to handle AccECN	Feb 1 2022, 1:40 PM
82112764b2c2	b882dfb4313b	305e6431cfcf	Richard Scheffenegger	manual rebase to main	Jan 31 2022, 12:22 PM
305e6431cfcf	5c946bfe69b3	8a2c0934c808	Richard Scheffenegger	- rebase to main - move tcp_set_flag() past ECN in rack_fast_output()	Feb 5 2022, 8:19 PM
8a2c0934c808	a00805882f52	6a6297363a47	Richard Scheffenegger	rebase to main, set flags in rsm_fast_output after ecn changes	Feb 4 2022, 11:16 PM
6a6297363a47	f6945cdad3e4	04056fde5b19	Richard Scheffenegger	Add/update AccECN related statistics and numbers (Show More…)	Feb 3 2022, 8:51 PM
04056fde5b19	77bc49d395e5	3522c8e5e4d1	Richard Scheffenegger	reconsile recent commits with local changes	Feb 3 2022, 8:34 PM
3522c8e5e4d1	bda10579dc1d	8b73b81fb4be	Richard Scheffenegger	add logging to troubleshoot iptos oddity	Feb 2 2022, 10:07 PM
8b73b81fb4be	800dca8ff230	bf28a7b54496	Richard Scheffenegger	use uint16_t consistently for thflags, rather than passing pointers	Feb 2 2022, 9:13 PM
bf28a7b54496	da5304a5af10	554eaf365494	Richard Scheffenegger	troubleshoot rack (ect0 on control packet)	Feb 2 2022, 6:48 PM
554eaf365494	9132c3a93771	c8d793a9bb27	Richard Scheffenegger	fixing cwr to go only with new data, update rack	Feb 2 2022, 4:13 PM
c8d793a9bb27	2d4d02c6a1a0	bb37386cd12d	Richard Scheffenegger	do proper output handling also for parallel SYN	Feb 2 2022, 2:14 PM
bb37386cd12d	457b92c611a0	0af3b5af39e3	Richard Scheffenegger	proper logging when handling ecn	Feb 2 2022, 12:03 PM
0af3b5af39e3	49a0f35f350d	10e8a289f032	Richard Scheffenegger	adding logging output, handle parallel SYN for ECN	Feb 2 2022, 10:05 AM
10e8a289f032	b17c725ec47f	038d7b31c893	Richard Scheffenegger	put more common ecn code to tcp_ecn.c	Feb 1 2022, 9:00 PM
038d7b31c893	d321e64989c0	2595572c9a60	Richard Scheffenegger	prepare rack to handle AccECN	Feb 1 2022, 1:40 PM
2595572c9a60	5ae30845618b	088a10673fee	Richard Scheffenegger	manual rebase to main	Jan 31 2022, 12:22 PM
088a10673fee	06bc111e5716	63770fe53a6f	Richard Scheffenegger	replace all macro references	Feb 2 2022, 7:33 PM
63770fe53a6f	346c79488192	09a43ffb8776	Richard Scheffenegger	use static inline function instead of macro	Feb 2 2022, 7:10 PM
09a43ffb8776	0899e7d34586	19fd03805073	Richard Scheffenegger	fix typo	Feb 1 2022, 4:21 PM
19fd03805073	db357ca71d92	be09b25466f4	Richard Scheffenegger	Access TCP Header Flags via accessor MACRO (Show More…)	Feb 1 2022, 4:06 PM
be09b25466f4	06bc111e5716	15a9d883394c	Richard Scheffenegger	only access exsting tp	Oct 13 2022, 5:50 AM
15a9d883394c	54a484ab373b	83c7e9b7cd0d	Richard Scheffenegger	don't assume tp, thflag exist	Oct 13 2022, 5:45 AM
83c7e9b7cd0d	958950b036e8	f83db6441a2f	Richard Scheffenegger	tcp_respond should react as expected for ECN in preparation for ECN++, AccECN	Oct 12 2022, 6:15 PM

Implement AccECN option (w/ early assigned option number)
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 112714

share/man/man4/tcp.4

sys/netinet/tcp.h

sys/netinet/tcp_ecn.c

sys/netinet/tcp_input.c

sys/netinet/tcp_output.c

sys/netinet/tcp_subr.c

sys/netinet/tcp_syncache.c

sys/netinet/tcp_usrreq.c

sys/netinet/tcp_var.h

Implement AccECN option (w/ early assigned option number)Needs ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 112714

share/man/man4/tcp.4

sys/netinet/tcp.h

sys/netinet/tcp_ecn.c

sys/netinet/tcp_input.c

sys/netinet/tcp_output.c

sys/netinet/tcp_subr.c

sys/netinet/tcp_syncache.c

sys/netinet/tcp_usrreq.c

sys/netinet/tcp_var.h

Implement AccECN option (w/ early assigned option number)
Needs ReviewPublic
Actions

Revision Contents
Changeset List