Details

Reviewers

jhb
markj
rew

Group Reviewers

bhyve

Commits

rG34520ce30b3c: bhyve: build HPET table by basl
rGd61d71229902: bhyve: build HPET table by basl

Summary

Building the HPET table by basl will allow it to be loaded by qemu's
ACPI table loader.

This is the 13. patch required to merge D36983

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 48348
Build 45234: arc lint + arc unit

Event Timeline

corvink created this revision.Oct 14 2022, 9:24 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptOct 14 2022, 9:24 AM

corvink requested review of this revision.Oct 14 2022, 9:24 AM

corvink mentioned this in D36983: bhyve: improve acpi table generation.Oct 14 2022, 9:35 AM

corvink retitled this revision from [acpi-table part 13] bhyve: build HPET table by basl to [PATCH 13/19] bhyve: build HPET table by basl.Oct 14 2022, 9:45 AM

markj accepted this revision as: markj.Oct 26 2022, 2:37 PM

markj added inline comments.

usr.sbin/bhyve/acpi.c
112	Missing a tab after the identifier.

This revision is now accepted and ready to land.Oct 26 2022, 2:37 PM

I've compared the ACPI output before and after this patch and fixed wrong entries

This revision now requires review to proceed.Nov 8 2022, 9:35 AM

Harbormaster completed remote builds in B48228: Diff 112770.Nov 8 2022, 9:35 AM

corvink marked an inline comment as done.Nov 8 2022, 9:35 AM

markj accepted this revision as: markj.Nov 8 2022, 6:43 PM

This revision is now accepted and ready to land.Nov 8 2022, 6:43 PM

jhb added a child revision: D36997: [PATCH 14/19] bhyve: build MADT table by basl.Nov 10 2022, 6:35 PM

jhb added a parent revision: D36995: [PATCH 12/19] bhyve: build MCFG table by basl.

inline defines

This revision now requires review to proceed.Nov 15 2022, 9:53 AM

Harbormaster completed remote builds in B48348: Diff 113126.Nov 15 2022, 9:53 AM

jhb accepted this revision.Nov 15 2022, 6:31 PM

This revision is now accepted and ready to land.Nov 15 2022, 6:31 PM

use ACPI_TABLE_* structs for building

This revision now requires review to proceed.Nov 16 2022, 12:51 PM

Harbormaster completed remote builds in B48386: Diff 113201.Nov 16 2022, 12:51 PM

corvink edited parent revisions, added: D37407: bhyve: add helper to fill a ACPI_GENERIC_ADDRESS; removed: D36995: [PATCH 12/19] bhyve: build MCFG table by basl.Nov 17 2022, 7:31 AM

jhb accepted this revision.Nov 17 2022, 5:57 PM

This revision is now accepted and ready to land.Nov 17 2022, 5:57 PM

Closed by commit rGd61d71229902: bhyve: build HPET table by basl. · Explain WhyNov 21 2022, 8:32 AM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rGd61d71229902: bhyve: build HPET table by basl.

corvink added a commit: rG34520ce30b3c: bhyve: build HPET table by basl.Dec 5 2022, 7:43 AM

[PATCH 13/19] bhyve: build HPET table by basl
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 113126

usr.sbin/bhyve/acpi.c

[PATCH 13/19] bhyve: build HPET table by baslClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 113126

usr.sbin/bhyve/acpi.c

[PATCH 13/19] bhyve: build HPET table by basl
ClosedPublic
Actions

Revision Contents
Changeset List