rk3308 minor patches for usb, ethernet, pwm,, temperature sensors
Needs ReviewPublic
Actions

Authored by titus_edc.ro on Jun 22 2023, 10:16 AM.

Details

Reviewers

andrew
manu

Summary

ported from linux, openbsd

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

titus_edc.ro created this revision.Jun 22 2023, 10:16 AM

Herald added a reviewer: andrew. · View Herald TranscriptJun 22 2023, 10:16 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added a subscriber: emaste. · View Herald Transcript

titus_edc.ro requested review of this revision.Jun 22 2023, 10:16 AM

andrew removed a subscriber: freebsd-arm-list.Jun 22 2023, 10:36 AM

andrew added inline comments.Jun 22 2023, 10:47 AM

sys/arm64/rockchip/if_dwc_rk.c
443	Why did you remove this white space?
467
524
sys/arm64/rockchip/rk_pwm.c
2	If this wrong it should be in a separate change
402–406

emaste added inline comments.Jun 22 2023, 12:08 PM

sys/arm64/rockchip/rk_pwm.c
2	This should not change

manu requested changes to this revision.Jun 22 2023, 1:11 PM

manu added inline comments.

sys/arm64/rockchip/if_dwc_rk.c
675	Not needed

This revision now requires changes to proceed.Jun 22 2023, 1:11 PM

fixed white space, 13.2 leftovers, etc

Please split this review per driver.

manu removed reviewers: arm64, manu.Dec 25 2023, 4:59 PM

Herald added a reviewer: manu. · View Herald TranscriptDec 25 2023, 4:59 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

rockchip/

59 line(s)

1 line

6 line(s)

1 line

21 line(s)

9 line(s)

Diff 123653

View Options

sys/arm64/rockchip/if_dwc_rk.c

View Options

sys/arm64/rockchip/rk_grf.c

View Options

sys/arm64/rockchip/rk_pwm.c

View Options

sys/arm64/rockchip/rk_spi.c

View Options

sys/arm64/rockchip/rk_tsadc.c

View Options

sys/arm64/rockchip/rk_usb2phy.c

rk3308 minor patches for usb, ethernet, pwm,, temperature sensorsNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 123653

sys/arm64/rockchip/if_dwc_rk.c

sys/arm64/rockchip/rk_grf.c

sys/arm64/rockchip/rk_pwm.c

sys/arm64/rockchip/rk_spi.c

sys/arm64/rockchip/rk_tsadc.c

sys/arm64/rockchip/rk_usb2phy.c

rk3308 minor patches for usb, ethernet, pwm,, temperature sensors
Needs ReviewPublic
Actions

Revision Contents
Changeset List