Page MenuHomeFreeBSD
Differential D5216

vmm/hyperv: code cleanup of utility drivers
ClosedPublic
Actions

Authored by howard0su_gmail.com on Feb 6 2016, 7:16 AM.
Tags
None
Referenced Files
F81969699: D5216.id13086.diff
Sat, Dec 14, 9:06 AM
F81969695: D5216.id13229.diff
Sat, Dec 14, 9:01 AM
F81969685: D5216.id13090.diff
Sat, Dec 14, 8:49 AM
F81969412: D5216.diff
Sat, Dec 14, 6:31 AM
Unknown Object (File)
Feb 25 2024, 6:56 AM
Unknown Object (File)
Feb 15 2024, 5:08 AM
Unknown Object (File)
Feb 15 2024, 5:08 AM
Unknown Object (File)
Feb 15 2024, 5:04 AM
View All Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
honzhan_microsoft.com
decui_microsoft.com
delphij
sepherosa_gmail.com
royger
adrian
Commits
rS295958: hyperv/utils: Code rearrange and cleanup
Summary
  1. give right driver name for devices, instead of hvutilx
  2. move global data into driver softc structure

kvp code cleanup will submit as a separate code review.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2414
Build 2430: arc lint + arc unit

Event Timeline

howard0su_gmail.com updated this revision to Diff 13086.Feb 6 2016, 7:16 AM
howard0su_gmail.com retitled this revision from to WIP: vmm/hyperv: code cleanup of utility drivers.
howard0su_gmail.com updated this object.
howard0su_gmail.com edited the test plan for this revision. (Show Details)
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptFeb 6 2016, 7:16 AM
howard0su_gmail.com updated this revision to Diff 13090.Feb 6 2016, 1:27 PM

Update hv_kvp driver using new hv_util functions

howard0su_gmail.com updated this revision to Diff 13129.Feb 8 2016, 4:25 PM

Fix hv_kvp and also cleanup a bit.

howard0su_gmail.com updated this revision to Diff 13229.Feb 11 2016, 1:30 PM

Cleanup KVP driver to remove all global variables.

howard0su_gmail.com added reviewers: sepherosa_gmail.com, decui_microsoft.com, honzhan_microsoft.com, delphij, royger.Feb 15 2016, 2:01 AM
howard0su_gmail.com updated this object.
honzhan_microsoft.com edited edge metadata.Feb 16 2016, 6:17 AM

Since there are some new added files, shall we modify the copyright to "2016"? I remember Sephie said there are some regulations on copyright.

sys/dev/hyperv/utilities/hv_heartbeat.c
3

Shall we update it to be "2016 Microsoft Corp."?

sepherosa_gmail.com edited edge metadata.Feb 16 2016, 6:19 AM
In D5216#112844, @honzhan_microsoft.com wrote:

Since there are some new added files, shall we modify the copyright to "2016"? I remember Sephie said there are some regulations on copyright.

I have not checked the file content yet. However, if majority of the content of the new file is copied from other file, we need to retain the source files copyright.

howard0su_gmail.com added a comment.Feb 17 2016, 12:03 PM
In D5216#112847, @sepherosa_gmail.com wrote:
In D5216#112844, @honzhan_microsoft.com wrote:

Since there are some new added files, shall we modify the copyright to "2016"? I remember Sephie said there are some regulations on copyright.

I have not checked the file content yet. However, if majority of the content of the new file is copied from other file, we need to retain the source files copyright.

Most newly added files contains code is copied from original files. I don't think we should change the copyright.

howard0su_gmail.com retitled this revision from WIP: vmm/hyperv: code cleanup of utility drivers to vmm/hyperv: code cleanup of utility drivers.Feb 17 2016, 12:03 PM
howard0su_gmail.com edited edge metadata.
howard0su_gmail.com added a reviewer: adrian.Feb 18 2016, 12:02 PM
adrian accepted this revision.Feb 18 2016, 6:21 PM
adrian edited edge metadata.
adrian added inline comments.
sys/dev/hyperv/utilities/hv_heartbeat.c
3

I'd update it to be 2014, 2016 Microsoft Corp.

This revision is now accepted and ready to land.Feb 18 2016, 6:21 PM
howard0su_gmail.com added a child revision: D5400: hyperv/vmbus: replace hv_guid with uuid.Feb 23 2016, 4:51 AM
Closed by commit rS295958: hyperv/utils: Code rearrange and cleanup (authored by sephe). · Explain WhyFeb 24 2016, 5:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
conf/
3 lines
3 lines
dev/
hyperv/
include/
35 lines
utilities/
129 lines
13 lines
278 lines
151 lines
216 lines
55 lines
395 lines
modules/
hyperv/
utilities/
2 lines

Diff 13090

View Options

sys/conf/files.amd64

Loading...
View Options

sys/conf/files.i386

Loading...
View Options

sys/dev/hyperv/include/hyperv.h

Loading...
View Options

sys/dev/hyperv/utilities/hv_heartbeat.c

Loading...
View Options

sys/dev/hyperv/utilities/hv_kvp.h

Loading...
View Options

sys/dev/hyperv/utilities/hv_kvp.c

Loading...
View Options

sys/dev/hyperv/utilities/hv_shutdown.c

Loading...
View Options

sys/dev/hyperv/utilities/hv_timesync.c

Loading...
View Options

sys/dev/hyperv/utilities/hv_util.h

Loading...
View Options

sys/dev/hyperv/utilities/hv_util.c

Loading...
View Options

sys/modules/hyperv/utilities/Makefile

Loading...