Add a sense subcommand to camcontrol(8)
ClosedPublic
Actions

Authored by ken on Dec 28 2023, 8:20 PM.

Details

Reviewers

mav
imp

Commits

rG658a9820b0bf: camcontrol: Add a sense subcommand
rG31a363933e9a: camcontrol: Add a sense subcommand
rG40a492d38ee1: camcontrol: Add a sense subcommand

Summary

This adds a sense subcommand to camcontrol.

There are situations where sending a REQUEST SENSE command to a device can yield helpful information. And sometimes it is necessary to do that without sending a TEST UNIT READY and getting autosense back.

blackpearl:/usr/home/kenm:!:0} camcontrol sense da10
(pass1:mps0:0:20:0): SCSI status: OK
(pass1:mps0:0:20:0): SCSI sense: NOT READY asc:4,4 (Logical unit not ready, format in progress)
(pass1:mps0:0:20:0): Progress: 4% (2946/65536) complete

sm4u-1-mgmt:/usr/home/kenm:!:0} camcontrol sense da1
(pass1:mps0:0:9:0): SCSI status: OK
(pass1:mps0:0:9:0): SCSI sense: NO SENSE asc:5e,5 (Idle-B condition activated by timer)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

ken requested review of this revision.Dec 28 2023, 8:20 PM

ken created this revision.

mav added inline comments.Dec 28 2023, 8:28 PM

sbin/camcontrol/camcontrol.c
941–942	It seems the status here will always be "OK". Not sure it worth printing. Plus it is confusing, since the original command that could produce the sense data without autosensing would likely return a "Check Condition".