Differential D7521

hyperv/storvsc: use SRB flag and CAM_SEL_TIMEOUT to filter invalid LUN
ClosedPublic
Actions

Authored by honzhan_microsoft.com on Aug 16 2016, 5:42 AM.

Tags

None

Referenced Files

	F81969661: D7521.id19321.diff
	Sat, Dec 14, 8:02 AM

	F81969649: D7521.id19318.diff
	Sat, Dec 14, 7:56 AM

	F81969289: D7521.diff
	Sat, Dec 14, 4:43 AM

	Unknown Object (File)
	Tue, Nov 19, 10:46 PM

	Unknown Object (File)
	Mon, Nov 18, 11:38 AM

	Unknown Object (File)
	Mon, Nov 18, 10:36 AM

	Unknown Object (File)
	Mon, Nov 18, 10:09 AM

	Unknown Object (File)
	Sat, Nov 16, 12:32 AM

View All 78 Files

Subscribers

Contributor Reviews (src)

Details

Reviewers

scottl
howard0su_gmail.com
decui_microsoft.com
hrs
delphij
sepherosa_gmail.com
royger

Commits

rS304251: hyperv/storvsc: Deliver CAM_SEL_TIMEOUT upon SRB status error.

Summary

This fixes the issue of failing to hot plugin more than 7 disks.

SRB flag is set to 0x20 if the specified LUN is invalid by Hyper-v host, and
the INQUIRY response will not be set by Hyper-v host. That is why INQUIRY
on invalid lun get all zero values. In addition, TUR (Test Unit Ready) command
on invalid LUN also makes SRB flag be 0x20.

VM shall response to CAM layer with CAM_SEL_TIMEOUT to filter those
invalid LUNs. Never use CAM_DEV_NOT_THERE which will block LUN scan
for LUN number higher than 7.

Submitted by: Hongjiang Zhang <honzhan microsoft com>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

honzhan_microsoft.com updated this revision to Diff 19318.Aug 16 2016, 5:42 AM

honzhan_microsoft.com retitled this revision from to hyperv/storvsc: use SRB flag and CAM_SEL_TIMEOUT to filter invalid LUN.

honzhan_microsoft.com updated this object.

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptAug 16 2016, 5:42 AM

honzhan_microsoft.com updated this object.Aug 16 2016, 5:46 AM

honzhan_microsoft.com added reviewers: scottl, sepherosa_gmail.com, decui_microsoft.com, delphij, hrs, royger, howard0su_gmail.com.

sepherosa_gmail.com accepted this revision.Aug 16 2016, 5:47 AM

sepherosa_gmail.com edited edge metadata.

This revision is now accepted and ready to land.Aug 16 2016, 5:47 AM

honzhan_microsoft.com updated this revision to Diff 19321.Aug 16 2016, 6:53 AM

honzhan_microsoft.com edited edge metadata.

honzhan_microsoft.com removed rS FreeBSD src repository - subversion as the repository for this revision.

This revision now requires review to proceed.Aug 16 2016, 6:53 AM

Closed by commit rS304251: hyperv/storvsc: Deliver CAM_SEL_TIMEOUT upon SRB status error. (authored by sephe). · Explain WhyAug 17 2016, 5:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

hyperv/

storvsc/

hv_storvsc_drv_freebsd.c

155 lines

6 lines

Diff 19377

head/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c

Loading...

head/sys/dev/hyperv/storvsc/hv_vstorage.h

Loading...