hyperv/util unify the negotitation for utils
ClosedPublic
Actions

Authored by honzhan_microsoft.com on Oct 19 2016, 9:51 AM.

Details

Reviewers

howard0su_gmail.com
decui_microsoft.com
hrs
delphij
sepherosa_gmail.com
royger

Commits

rS307845: hyperv/ic: Rework framework/message version negotiation.

Summary

Unify the negotiation for shutdown/timesync/heartbeat/kvp, and add the log for selected version.

On windows 2012 or 2016, the negotiation version for both KVP and timesync does not match the Hyper-V expectation. The command "Get-VMIntegrationService" will output "The protocol version of the component installed in the virtual machine does not match the version expected by the hosting system". We have to upgrade the version of KVP and time sync on VM side. That is future work.

Submitted by: Hongjiang Zhang <honzhan microsoft com>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

honzhan_microsoft.com updated this revision to Diff 21490.Oct 19 2016, 9:51 AM

honzhan_microsoft.com retitled this revision from to hyperv/util unify the negotitation for utils.

honzhan_microsoft.com updated this object.

honzhan_microsoft.com edited the test plan for this revision. (Show Details)

honzhan_microsoft.com updated this object.Oct 19 2016, 9:54 AM

honzhan_microsoft.com added reviewers: decui_microsoft.com, sepherosa_gmail.com, hrs, delphij, royger.

honzhan_microsoft.com added a reviewer: howard0su_gmail.com.

sepherosa_gmail.com added inline comments.Oct 20 2016, 1:43 AM

sys/dev/hyperv/utilities/hv_kvp.h
152 ↗	(On Diff #21490)	I don't think these changes are related to the topic here.
sys/dev/hyperv/utilities/hv_util.c
58 ↗	(On Diff #21490)	I don't like this, driver should have this instead of gathering them here.
96 ↗	(On Diff #21490)	These should be in each driver.
156 ↗	(On Diff #21490)	Can you keep the vmbus_ic_negomsg? I don't want to rename this function again.
159 ↗	(On Diff #21490)	I have already defined a new message for negotiate. Please don't use the old one.
169 ↗	(On Diff #21490)	Use the new message, this type of accessing is ugly.
178 ↗	(On Diff #21490)	Same as above comment.