Patch submitted directly by email to me by a user, forwarded to and validated by the port maintainer.
And during a poudriere testport, I've noticed that I had to replace an old WITH_OPENSSL_PORT.
poudriere testport logs:
Details
- Reviewers
tabthorpe jadawin - Commits
- rP430473: Fix build with libressl
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 6352 Build 6591: arc lint + arc unit
Event Timeline
irc/hexchat/Makefile | ||
---|---|---|
6 | Why do you bump PORTREVISION here? | |
82 | Since 9.x is nearing EOL, I plan to remove this entry with the next update, so I believe it's not necessary to change it, however if you insist on doing this, I don't mind. |
Remove bump PORTREVISION: It's a "Build fixes which cause a package to become compilable where it was previously failing" case.
irc/hexchat/Makefile | ||
---|---|---|
6 | I'm never confident when I need to increment the PORTREVISION, then when I've got a doubt I update it. | |
82 | I was just trying to push the more "clean" possible port for increase my chance to pass the mentors filter :-) |
irc/hexchat/Makefile | ||
---|---|---|
82 | Setting DEFAULT_VERSIONS from a port is impoper. Use this construct in stead .if ${SSL_DEFAULT} == base IGNORE_FreeBSD_9= Requires newer OpenSSL (set DEFAULT_VERSIONS+=ssl=openssl) .endif | |
irc/hexchat/files/patch-src__common__ssl.c | ||
8 | Please append the additional check rather than prepending it. Makes the diff easier to understand -#if OPENSSL_VERSION_NUMBER < 0x10100000L +#if OPENSSL_VERSION_NUMBER < 0x10100000L || defined(LIBRESSL_VERSION_NUMBER) |
irc/hexchat/Makefile | ||
---|---|---|
82 | Since 9-STABLE is now EOL, this whole .if block may be removed now. |
@olivier
And since it's been over two weeks, could you call it mentor timeout (similar to maintainer timeout) and just commit it? :)
Nope! :)
Sorry, i was on vacations with no internet access. Oliver was aware about that and his co-mentor, too.
I think this can be closed, builds OK currently with LibreSSL 2.7
https://keg.brnrd.eu/data/111amd64-default-libressl/2018-03-25_17h53m17s/logs/hexchat-2.12.4.log