Enable the SDHCI controller on ARMADA38X
ClosedPublic
Actions

Authored by loos on May 5 2017, 3:18 AM.

Details

Reviewers

Commits

Summary

Add the Marvell SDHCI controller the list of supported devices in sdhci_fdt.

Enable the SDHCI controller, bus and devices on ARMADA38X kernel.

Depends on: D10601, D10602
Sponsored by: Rubicon Communications, LLC (Netgate)

Test Plan

Tested on ClearFog Pro.

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

loos retitled this revision from Enable the SDHCI controller for ARMADA38X to Enable the SDHCI controller on ARMADA38X.May 5 2017, 5:19 AM

sys/dev/sdhci/sdhci_fdt.c
196	Hi, Have you checked other quirks with linux drivers/mmc/host/sdhci-pxav3.c? Also, I think this driver is also missing setting bus width - I guess it's always "4", right?

sys/dev/sdhci/sdhci_fdt.c
196	Yes, the other quirks are not applicable for our SDHCI layer (we are still using SDMA) or are not applicable to this hardware. The quirks were also checked against the NetBSD drivers (where I found the missing bits): https://nxr.netbsd.org/xref/src/sys/arch/arm/marvell/mvsoc_sdhc.c#83 The SDHCI code seems to be doing the right thing with respect to bus-width. If necessary we can handle it based on FDT properties.

sys/dev/sdhci/sdhci_fdt.c
196	Thanks. I think we can add bus-width handling and parsing in the separate patch (a38x supports 8-bits as well and with current code we won't make use of it). Other than that I'm ok with the patch, thanks!