Page MenuHomeFreeBSD
Differential D12267

Fix an infinite loop in tcp_tw_2msl_scan() when an INP_TIMEWAIT inp has been destroyed before its tcptw with INVARIANTS undefined.
ClosedPublic
Actions

Authored by jch on Sep 7 2017, 3:12 PM.
Tags
None
Referenced Files
F81969811: D12267.id33615.diff
Sat, Dec 14, 10:54 AM
F81969650: D12267.diff
Sat, Dec 14, 7:57 AM
Unknown Object (File)
Wed, Nov 27, 12:04 PM
Unknown Object (File)
Tue, Nov 19, 11:55 AM
Unknown Object (File)
Sun, Nov 17, 2:43 AM
Unknown Object (File)
Sun, Nov 17, 2:37 AM
Unknown Object (File)
Sat, Nov 16, 10:56 PM
Unknown Object (File)
Sat, Nov 16, 8:03 PM
View All 32 Files
Subscribers
j-nitrology.com
kbowling
mjoras

Details

Reviewers
• hselasky
mjoras
Group Reviewers
transport
Commits
rS324948: MFC r324179, r324193:
rS324179: Fix an infinite loop in tcp_tw_2msl_scan() when an INP_TIMEWAIT inp has
Summary

Fix an infinite loop in tcp_tw_2msl_scan() when an INP_TIMEWAIT inp has been destroyed before its tcptw wint INVARIANTS undefined.

This is a symmetric change of r307551:

A INP_TIMEWAIT inp should not be destroyed before its tcptw, and INVARIANTS
will catch this case. If INVARIANTS is undefined it will emit a log(LOG_ERR)
and avoid a hard to debug infinite loop in tcp_tw_2msl_scan().

Reported by: Ben Rubson, hselasky
Submitted by: hselasky
Tested by: Ben Rubson, jch
MFC after: 1 week
Sponsored by: Verisign, inc

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
head/
sys/
netinet/
27 lines

Diff 33615

View Options

head/sys/netinet/tcp_timewait.c

Loading...