Introduce test-program for ioctl(2) syscall
ClosedPublic
Actions

Authored by aniketp on Jun 17 2018, 8:30 PM.

Details

Reviewers

asomers
rwatson
gnn

Commits

rS335354: audit(4): add tests for ioctl(2)

Summary

This revision introduces the test-program for ioctl audit class which only contains
ioctl(2) as the audit event.

Test Plan

Execute make && make install from test/sys/audit.
Execute kyua test from /usr/tests/sys/audit. All testcases should succeed.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17427
Build 17259: arc lint + arc unit

Event Timeline

aniketp created this revision.Jun 17 2018, 8:30 PM

Harbormaster completed remote builds in B17387: Diff 43969.Jun 17 2018, 8:30 PM

asomers requested changes to this revision.Jun 17 2018, 10:18 PM

asomers added inline comments.

tests/sys/audit/ioctl.c
58	`ioctl` is superversatile. Does it audit the request too? If so, can you test for that in the regex?
62	This is probably not a good ioctl to test with, because it might flush the audit record of interest. How about something more harmless, like AUDITPIPE_GET_QLIMIT ?

This revision now requires changes to proceed.Jun 17 2018, 10:18 PM

Verify the audit of hex(request) in the ioctl(2)'s audit record

@asomers I have opened a separate instance of /dev/auditpipe for the test-case, so it doesn't
matter what is flushed from this device instance, since it is not of our concern.
Also, I pondered initially about which request to use, I chose AUDITPIPE_FLUSH because
it is the simplest of all available options.

Harbormaster completed remote builds in B17398: Diff 43987.Jun 18 2018, 5:24 AM

asomers added inline comments.Jun 18 2018, 3:43 PM

tests/sys/audit/ioctl.c
60	Pro tip: the "#" character tells printf(3) to use an "alternate form", which has different meanings depending on the type of conversion. For example, `printf("%#x", 16)` will print `0xa`.