readelf -wo used to just show the main offset for each entry. Fix it so that the offset is specific to each entry.
submitted by: Bora Ozarslan borako.ozarslan@gmail.com
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Note, Dwarf_Locdesc is part of the public ABI, so this change would require a library version number bump; see SHLIB_MAJOR in lib/libdwarf/Makefile.
Did you consider adding a len field to Dwarf_Loc instead? Consumers can easily sum up the expressions for a given description and add the fixed dwarf_get_address_size(dbg) + 2.
| contrib/elftoolchain/libdwarf/libdwarf.h | ||
|---|---|---|
| 123 ↗ | (On Diff #54090) | This field should be documented in the dwarf_loclist.3 man page. |
| contrib/elftoolchain/libdwarf/libdwarf_loclist.c | ||
| 76 ↗ | (On Diff #54090) | This field is just being left uninitialized in the other spot where _dwarf_loc_fill_locdesc() gets called. |
| contrib/elftoolchain/readelf/readelf.c | ||
| 6521 ↗ | (On Diff #54090) | I don't think this part of the change is really necessary. It's fine to have the extra duplicates variable, and you can avoid the ugly casts. |
| 6544 ↗ | (On Diff #54090) | Style: indentation. |
Comment Actions
I don't think I considered using Dwarf_Loc instead of Dwarf_Locdesc. It made more sense to show it per Dwarf_Loc like you said so I converted to that.