Some hardware/firmware leaves serial console in bogus state before calling user boot code. After that output of boot0sio could not be seen by user, which is inconvenient.
This diff adds compile-time option BOOT_BOOT0_RESET_TERM, which force boot0sio to send default VT-100 reset command <ESC>c before all output.
This option is not compatible with PXE and VOLUME_SERIAL options, due to space constrains. Only two of these three options could be selected together.
This option is turned off by default.
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| stand/i386/boot0sio/Makefile | ||
|---|---|---|
| 8 | We're trying to migrate to -DWITH_BOOT0_RESET_TERM style, so please use that here if you can by adding that variable in src.conf, etc. | |
| stand/i386/boot0sio/Makefile | ||
|---|---|---|
| 8 | No. Like this .include <src.opts.mk> .if ${MK_BOOT0_RESET_TERM} != "no" | |
| tools/build/options/WITH_BOOT0_RESET_TERM | ||
|---|---|---|
| 5 ↗ | (On Diff #57220) | constraints. |
| stand/i386/boot0/Makefile | ||
|---|---|---|
| 17 | send terminal reset command when, under what conditions? I see the addition which feeds into src.conf.5, but does this need to be mentioned elsewhere, such as boot.8 or boot0cfg.8? | |
| tools/build/options/WITH_BOOT0_RESET_TERM | ||
| 3 ↗ | (On Diff #57220) | before all output can be read two different ways:
Please clarify. |
| stand/i386/boot0/Makefile | ||
|---|---|---|
| 17 | Other boot0[sio] options are not described in boot.8 or boot0cfg.8, so I haven't add new option there. | |
| stand/i386/boot0/boot0.S | ||
|---|---|---|
| 597 | s/teminal/terminal/ | |
Comment Actions
I think this is good. There's many other strings we might consider for the reset, but this is good.