Integrate zstd support into the boot loader, from earlier work by Matt Macey.
Details
- Reviewers
tsoome mmacy - Commits
- rS366657: Add zstd support to the boot loader.
Make sure the last minutes shuffling I did didn't break the kernel and/or userland
builds.
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 33219 Build 30562: arc lint + arc unit
Event Timeline
Generally happy about the cleanup and the added flexibility in the build infrastructure.
Changes to the ifdefs/if defined could use a pass to check for consistency of the comments on the closing endif.
sys/contrib/openzfs/module/os/freebsd/spl/list.c | ||
---|---|---|
30 | This is normally included on the command line. I don't think we should start being inconsistent about that here. | |
sys/contrib/openzfs/module/zstd/zfs_zstd.c | ||
46 | Is this order important or can the zio_compress.h include just be pulled out of the if and avoid the else? | |
84 | This seems like a weird place to do this. |
sys/contrib/openzfs/module/os/freebsd/spl/list.c | ||
---|---|---|
30 | It's quite unusual wrt rest of FreeBSD and the boot loader to do this for anything but the global #define options in the kernel... | |
sys/contrib/openzfs/module/zstd/zfs_zstd.c | ||
46 | Unsure. I'll try it. | |
84 | Yea, I didn't want to get into the tangled mess of where it's defined, but that may be a fair bit of feedback. |
sys/contrib/openzfs/lib/libspl/include/os/freebsd/sys/param.h | ||
---|---|---|
48–50 | This change from ifndef to ifdef is concerning. What's going on here? |
sys/contrib/openzfs/lib/libspl/include/os/freebsd/sys/param.h | ||
---|---|---|
48–50 | That's likely a mistake. I'll bet it can be removed entirely. |
Rebase and rework after comments from the OpenZFS upstreaming
to reduce diffs in upstream files. I was able to flesh out
the _STANDALONE support in the spl for FreeBSD instead of
some surgery in upstream files.