Page MenuHomeFreeBSD

atomic: add atomic_interrupt_fence()
ClosedPublic

Authored by kib on Feb 24 2021, 10:50 AM.
Tags
None
Referenced Files
F81910191: D28909.id84601.diff
Sun, Dec 1, 8:14 PM
Unknown Object (File)
Sat, Nov 30, 4:12 AM
Unknown Object (File)
Sat, Nov 30, 1:12 AM
Unknown Object (File)
Fri, Nov 29, 5:54 AM
Unknown Object (File)
Wed, Nov 27, 5:23 PM
Unknown Object (File)
Fri, Nov 22, 3:09 AM
Unknown Object (File)
Sun, Nov 17, 11:44 PM
Unknown Object (File)
Sat, Nov 9, 4:22 AM
Subscribers
None

Details

Summary

with the semantic following C11 signal_fence, that is, it establishes ordering between its place and any interrupt handler executing on the same CPU.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Feb 24 2021, 10:50 AM
kib created this revision.
This revision is now accepted and ready to land.Feb 24 2021, 10:56 AM
rlibby added inline comments.
share/man/man9/atomic.9
34

Comma?

298–305

Apologies in advance for nitpicking grammar, but since this is the man page (which by the way is excellent overall):

Interrupt Fence Operation

I think should be plural, like Thread Fence Operations is.

It is modelled after similar C11 function
.Fn atomic_signal_fence() ,
adapted for the kernel environment.

Suggestions:

It is modelled after the similar C11 function
.Fn atomic_signal_fence() ,
and adapted for the kernel environment.

Additionally my spell check wants "modelled" to have one L, but I think this is a regional thing and I'm not sure if we're consistent about that.

kib marked 2 inline comments as done.

Man page fixes.

This revision now requires review to proceed.Feb 24 2021, 8:46 PM
This revision is now accepted and ready to land.Feb 24 2021, 8:48 PM
This revision was automatically updated to reflect the committed changes.